Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Zhang Changzhong <zhangchangzhong@huawei.com>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "Michal.Kalderon@cavium.com" <Michal.Kalderon@cavium.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net] qed: fix error return code in
 qed_iwarp_ll2_start()
Thread-Topic: [EXT] [PATCH net] qed: fix error return code in
 qed_iwarp_ll2_start()
Thread-Index: AQHWvBkzDchIUpfrckW+tkNp0UefRqnLKq1Q
Date:   Mon, 16 Nov 2020 19:48:41 +0000
Message-ID: <MN2PR18MB31826BF70A73AA243121013FA1E30@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <1605532033-27373-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1605532033-27373-1-git-send-email-zhangchangzhong@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68ad80ef-2df3-4b22-886b-08d88a689e94
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 19:48:41.2632
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: StXLEAdLxq8DbvYYbDv7LR4EPYeu7zUcrrTEEf569TQ9e9LJujkiD9nfxtRV9BJXQstGUWFVVmBrvvYFK5lZaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3575
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-16_09:2020-11-13,2020-11-16 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Zhang Changzhong <zhangchangzhong@huawei.com>
> Sent: Monday, November 16, 2020 3:07 PM
>=20
> ----------------------------------------------------------------------
> Fix to return a negative error code from the error handling case instead =
of 0,
> as done elsewhere in this function.
>=20
> Fixes: 469981b17a4f ("qed: Add unaligned and packed packet processing")
> Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and
> processing mpa fpdus")
> Fixes: 1e28eaad07ea ("qed: Add iWARP support for fpdu spanned over more
> than two tcp packets")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> index 512cbef..a998611 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> @@ -2754,14 +2754,18 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,
>  	iwarp_info->partial_fpdus =3D kcalloc((u16)p_hwfn->p_rdma_info-
> >num_qps,
>  					    sizeof(*iwarp_info->partial_fpdus),
>  					    GFP_KERNEL);
> -	if (!iwarp_info->partial_fpdus)
> +	if (!iwarp_info->partial_fpdus) {
> +		rc =3D -ENOMEM;
>  		goto err;
> +	}
>=20
>  	iwarp_info->max_num_partial_fpdus =3D (u16)p_hwfn->p_rdma_info-
> >num_qps;
>=20
>  	iwarp_info->mpa_intermediate_buf =3D kzalloc(buff_size,
> GFP_KERNEL);
> -	if (!iwarp_info->mpa_intermediate_buf)
> +	if (!iwarp_info->mpa_intermediate_buf) {
> +		rc =3D -ENOMEM;
>  		goto err;
> +	}
>=20
>  	/* The mpa_bufs array serves for pending RX packets received on
> the
>  	 * mpa ll2 that don't have place on the tx ring and require later @@ -
> 2771,8 +2775,10 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,
>  	iwarp_info->mpa_bufs =3D kcalloc(data.input.rx_num_desc,
>  				       sizeof(*iwarp_info->mpa_bufs),
>  				       GFP_KERNEL);
> -	if (!iwarp_info->mpa_bufs)
> +	if (!iwarp_info->mpa_bufs) {
> +		rc =3D -ENOMEM;
>  		goto err;
> +	}
>=20
>  	INIT_LIST_HEAD(&iwarp_info->mpa_buf_pending_list);
>  	INIT_LIST_HEAD(&iwarp_info->mpa_buf_list);
> --
> 2.9.5

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>