Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ef625c1e21c492be8c423730e45e90d92b1ae899.camel@decadent.org.uk>
Subject: Re: drivers/accessibility/speakup/serialio.c:48:19: warning:
 variable 'quot' set but not used
From:   Ben Hutchings <ben@decadent.org.uk>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Mon, 16 Nov 2020 19:51:23 +0000
In-Reply-To: <20201116190122.yslib3wicn45rbuo@function>
References: <202011160942.AmYkxiJv-lkp@intel.com>
         <20201116190122.yslib3wicn45rbuo@function>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-lNInYjliUYrP/BVGlU8T"
User-Agent: Evolution 3.36.4-2 
MIME-Version: 1.0
Precedence: bulk


--=-lNInYjliUYrP/BVGlU8T
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote:
> Hello Ben,
>=20
> A long time ago you added a dependency for speakup drivers on
> CONFIG_ISA, and you also added || COMPILE_TEST as an alternative.
>=20
> It seems that some platform portability tests then think they should
> be able to build it, even if they don't enable ISA, but then we are
> getting warnings, or even errors, depending on the compatibility macros
> in <asm/io.h> in the !ISA case (here, the parisc compatibility macros do
> not consume their parameter).
>=20
> Perhaps we should rather use
>=20
> depends on ISA || (X86 && COMPILE_TEST)
>=20
> ?
> so that we have compile testing on x86 only (where the inb/outb macros
> always behave fine) to avoid such issues on other archs?

That seems reasonable though unusual.

> Or we tell the architecture maintainers to fix their out macros into
> consuming their parameters?
[...]

It does seem odd for parisc to define the I/O functions this way.  I
don't know if it's really a bug.

Ben.

--=20
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                      - Albert Einstein


--=-lNInYjliUYrP/BVGlU8T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAl+y2DsACgkQ57/I7JWG
EQkz+w//UfnbQDFWLWLce0U9xQUMBvXQhuN6tanVINl3C4BPgNWRJgT4dPTtZc2g
DZoD+7AgT2Tlckt7T4y26vFD0sRPzB1Y994t/xgLc6KTvFZRAQh+wAjLTHBSeLR8
CxBgVQvoVsgKuJvcb2hW/F6LHYu5sYjyMr0Xe9xEkq0YEMyO9ye6mtSSQBJjYuYS
LmdBkVgbcTF8SrM8ekf7ZzEA/CFkgv0KnpGMW4MVyQsjX9WnXFK/tE2rwxDeFmym
zab7OW0pfYvdlDlkmX/r+G1sK2/uT8PMDkLwXEEYU31a5b0aAJcev/Q8uEFHbZ14
shQxgY8VOlmujpX+W0RoK84v73Za/y16m7SolZbg0ECGkKz65QaoqlezXYZotD9l
YEujqTo2Fu8tw/5bJz7vvv4NBqU3Lkk70cjojjmDQeySMVQP6efHyoLDRqd/hwZh
BFmPQZrEKCT1xeu5iTElOibNhQcMYQV3VUi30S/asqywifmTcDqEgSoLB0RkF5KE
qB/J1V+VUe6c6tlCOg5BwAbFK9iYZBkfgI2bj7UcpCnvfNBnRk3zJ0uJwqeIHLnE
D2t1fFomvyIUy82GBwQuEkmvm64RJmiXpnr1j08bNgla/jG4QGf1wg0dFxuRNntQ
cycqRNq/ouBx6/mj2mv3nOaAfxLEiMru9/nDgid7bYgbxZB2Avw=
=lQdv
-----END PGP SIGNATURE-----

--=-lNInYjliUYrP/BVGlU8T--