Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 16 Nov 2020 13:12:24 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Tom Rix <trix@redhat.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        <clang-built-linux@googlegroups.com>,
        <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcg: remove obsolete memcg_has_children()
Message-ID: <20201116211224.GA45468@carbon.dhcp.thefacebook.com>
References: <20201116055043.20886-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201116055043.20886-1-lukas.bulwahn@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:42f) by CO2PR04CA0202.namprd04.prod.outlook.com (2603:10b6:104:5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25 via Frontend Transport; Mon, 16 Nov 2020 21:12:28 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eff15417-37c9-40df-535c-08d88a74537e
X-MS-TrafficTypeDiagnostic: BYAPR15MB2710:
X-Microsoft-Antispam-PRVS: <BYAPR15MB27100A0B3EB919E2B6061D47BEE30@BYAPR15MB2710.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fJcwVOEEwB6X067BDJkKsdizni1sIhDgG/Rovafz2ZxQI9FwxT6yWr9kAJoYaifB+i/VhiwA8YdovOjzfyOZ6Z02G/uKug6Hnhb9VzdlZzN8SlIEGLia/GNVP6A5GP3xxnopAgjTXq69u1wYGCVwjy6oF6VPobncwO8+zWqJZ9TXao74so9SVMKcyNxYlHESmsYB2Zi3T4fAagXQKsybQwHqr9gx3KgLW6l5xvk/tXh8lt/TseNBygDcqjMkhItlnrSJ5btTC7JdeLhK2svo1MT6FlU1zZ5tW1710+DJ8rIxwd2xAU/53jDuXd4Oydzj
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(376002)(366004)(346002)(39860400002)(54906003)(316002)(7696005)(52116002)(6506007)(66476007)(66556008)(66946007)(16526019)(186003)(4326008)(478600001)(5660300002)(4744005)(1076003)(83380400001)(8676002)(8936002)(33656002)(9686003)(7416002)(55016002)(86362001)(6916009)(2906002)(6666004);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: Me7guhPtroKjVxPTKr0uc8prD0LiHFnmhRmO3W8WYh5ZsSwqWL5tbc3oH0z3CzW/ZhNrmns8sFIqvlpnkYtSJ4dWj01VY35S7I9GRxeNujxEe5e35p31zI23ESHh5tTYH8HWvTHS5A1TQGnknK43lZWnRjprxFgBsl/oCdB+Rct06X22tB2gz536hmwbuy38HsbPdSVEr83SEj3sDwjlQuDsO88rk+EliWRQ9frvoueJwTExYJFCQUVNzClYZsg50r87Mh4O3v8r+BrmLuFO26yl3QpQqxjV+Ypfyxz4xVYSrHBJ3760bfmMh6azgpjdVVPG30k7nR/Kt3PK+JAR97JXKUsImaznkuTTHvZDKC5EnaNIdNv5rHfOD6XTPhDJbEBIyLHAVsgTlM9qU5zgpDqIbWppnlc445CKKXL5yJY5IUPSWMhL20H7df3IoJUKzoxdOUIaJD4O642CvW/shuBonGkHctIl/HYTeUAoSVJ0j2MGEdgbPdWjJoF5BCO4iZTQNADkzm8Kq6BlIOuOs6Og6RffF+6eK3RuoWtZGEtaIa7Trdcj8XGzO8quS9ESQX3esKmqNkqGjtGtiFuB7K0DJ6BV/PU/OweQ1PRtJUVWskaCcN++7BtPK7Q9zIDQqN8esLEz0JO8atpzXKLU5kxiWGF8peyJcaM6G0PVdts=
X-MS-Exchange-CrossTenant-Network-Message-Id: eff15417-37c9-40df-535c-08d88a74537e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 21:12:29.5881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CJ4mKEihpNadE6xtI3JP7PPwhKiKIlKmKpFtUiAVH/Yk7FwEvt9v8kH0WyKIxLp7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2710
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-16_11:2020-11-13,2020-11-16 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0
 adultscore=0 mlxlogscore=623 suspectscore=1 mlxscore=0 clxscore=1011
 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2011160126
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 16, 2020 at 06:50:43AM +0100, Lukas Bulwahn wrote:
> Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode")
> removed the only use of memcg_has_children() in
> mem_cgroup_hierarchy_write() as part of the feature deprecation.
> 
> Hence, since then, make CC=clang W=1 warns:
> 
>   mm/memcontrol.c:3421:20:
>     warning: unused function 'memcg_has_children' [-Wunused-function]
> 
> Simply remove this obsolete unused function.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on next-20201113, not on current master
> 
> Roman, please ack.

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!