Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <alpine.DEB.2.22.394.2011161633240.2682@hadrien>
References: <alpine.DEB.2.22.394.2011161633240.2682@hadrien>
From:   Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings
To:     Andrew Lunn <andrew@lunn.ch>,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Julia Lawall <julia.lawall@inria.fr>,
        Russell King <linux@armlinux.org.uk>
Cc:     Quentin Schulz <quentin.schulz@bootlin.com>,
        kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Denis Efremov <efremov@linux.com>,
        netdev@vger.kernel.org
Message-ID: <160556130103.369564.5641893167437988724@surface.local>
Date:   Mon, 16 Nov 2020 22:15:01 +0100
Precedence: bulk

Hello Julia,

Quoting Julia Lawall (2020-11-16 16:34:44)
> From: kernel test robot <lkp@intel.com>
>=20
> Condition !A || A && B is equivalent to !A || B.
>=20
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>=20
> Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
> CC: Denis Efremov <efremov@linux.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Reviewed-by: Antoine Tenart <atenart@kernel.org>

Thanks!
Antoine

> ---
>=20
> v2: add netdev mailing list
>=20
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master
> head:   e28c0d7c92c89016c12a677616668957351e7542
> commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add ex=
cluded_middle.cocci script
> :::::: branch date: 8 hours ago
> :::::: commit date: 8 weeks ago
>=20
> Please take the patch only if it's a positive warning. Thanks!
>=20
>  mscc_ptp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> --- a/drivers/net/phy/mscc/mscc_ptp.c
> +++ b/drivers/net/phy/mscc/mscc_ptp.c
> @@ -136,7 +136,7 @@ static void vsc85xx_ts_write_csr(struct
>=20
>         phy_ts_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_158=
8);
>=20
> -       if (!cond || (cond && upper))
> +       if (!cond || upper)
>                 phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_MSB, upper=
);
>=20
>         phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_LSB, lower);