Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3438494pxb; Mon, 16 Nov 2020 14:59:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJykNGOtWwfjlsM4nG6Q12sCmBfQICAGkrH50/vQNsiDLFAIGgYIz3QTbYod8CSwcLIJ87o6 X-Received: by 2002:a17:906:2b06:: with SMTP id a6mr17727603ejg.283.1605567552412; Mon, 16 Nov 2020 14:59:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605567552; cv=none; d=google.com; s=arc-20160816; b=Izqehqd7iN6sceYrrhCEC3QxSHPnMrtFGV8KQTm7vTso23jxrP/vzrvXmjJXE0leSx lEQwzRNrKmoBqvCiLVq2wOdoElLCs9NRBScRkPLvXKCMcVnPGIJP0CxgD2IqxfXGxp0P 2pycv2uiKr0ROubwibPUTH21K6ycKcHqxYAFcEZikW7GOgXkdYQrhG9QThrGJHNTFYhv OUqA8OBPq2d+JgbxCtS6tYrExppP9FX7iLzDLG1mws0P116lGUmju7DlUgJQvcvXE1b2 5VYtL6+9+Ik8lt+uZLAp6A0XajlYhU1TZ3/NoInyNIG7O3A+g74rShI8lVRMa1a9L7f5 6eHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DUgq39nfUV6cfcgfxfVRyyih0cIl6dnKtUhLRhxAR+8=; b=04XA5JniOphbyFrf2OCkvVnA1rQR2u3FF9gymACiPhyCXD++VYB8qxQEs3wniXFJlI xd/wj80bS/JgGg/OBfxIbgrdDu9ZwhNCWFsRsLpkax5Y7KC3VNimCRZr4lDRSvX/C/fw YHe2HFq6ViEDTZrt/IHsKY2pfcTtqblRrojlSUlkmQyRw2we3uaoi3fD3+SQmP1H32O7 mj+PyZA54w9Bbuq60r5PJst6q+OzZ/Q3XHzfRYyW2pjZhfrlOeGyDOHwiYYxUCGOvyh8 JncgCb0I0WF4xeis9uYulZH/Kh6vgjGAWapbT/82K87zydUhWnzjcpnu/tXf+5Li2wS2 TBwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="U/k3Myy9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si12699262edy.145.2020.11.16.14.58.49; Mon, 16 Nov 2020 14:59:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="U/k3Myy9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbgKPWUs (ORCPT + 99 others); Mon, 16 Nov 2020 17:20:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbgKPWUs (ORCPT ); Mon, 16 Nov 2020 17:20:48 -0500 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1097C0613D2 for ; Mon, 16 Nov 2020 14:20:46 -0800 (PST) Received: by mail-oi1-x242.google.com with SMTP id m143so20511568oig.7 for ; Mon, 16 Nov 2020 14:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUgq39nfUV6cfcgfxfVRyyih0cIl6dnKtUhLRhxAR+8=; b=U/k3Myy9d4B9JeG1yp4ijBWOlH6ytTjS1YEOx4zdkJtETmgqKqNIPx6ZqFcFFJ9jRd c2L2mWUlTCFFepINyZ3ucBt3IZfTzyglFc3WgRNKApnVhzFLZKtRfctObxioosHL8q2u ImWhWOXgEwyzpS4tUSftvGsokGC+f8veDL7AER9uzzvJ5g8Q79eLC3PaSw9Lwf4jofmM TehjzoFP4TkqZE/fhHjOt+jXUTRHr61oSn5PZjvBsqo4DkHp/uDr8nHBk007+jCz72MO nArnZRh6/SG8S2cyBcrHH4pkmB0wW17tQB2Wmer/vmbL6tV0VXBb/mQJEqcM0txm1ipb FoWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUgq39nfUV6cfcgfxfVRyyih0cIl6dnKtUhLRhxAR+8=; b=eWbmqU6Jtib9PokazwSg0Pd+jFfsKLUpYQSLpTZ5Z0PDzzPwGsm6liqBmY2tKFSnY0 YE/L/VWvAywiq6pnx3KBeoM3OhLNOQvQF4IbCk1Rs0mG1IbjniepfsinSdirP/PC9jTI v0OoGhCDMBGHdJyd3/V8dVDlns11jmv/pV85n564+uKv8yjJh4kA0wPkgxD43qxwF9aw zUXYpVyuXh+04QVa0LjaDHkjCZihhipluAczHERB2+t+5UmXShAoZoM/3Qi1YIM/4EWh ZFpMOLW8zaDgshI7DFzXggLafJzFCWtMynI6I+u5wZfBsmg9hgjw71mQYzqg8WUx+Xe0 C5/w== X-Gm-Message-State: AOAM5319XNamSp9FGuzLkxyVogLSDZHq5k4iULUlCrR+SJHJbmnMimdT OiiE/hKwMjF/Ms1ELVEESLVQaaPfW63KB9pZoNKSTg== X-Received: by 2002:aca:4fc7:: with SMTP id d190mr579597oib.13.1605565245760; Mon, 16 Nov 2020 14:20:45 -0800 (PST) MIME-Version: 1.0 References: <20201116181126.2008838-1-pbonzini@redhat.com> In-Reply-To: <20201116181126.2008838-1-pbonzini@redhat.com> From: Jim Mattson Date: Mon, 16 Nov 2020 14:20:34 -0800 Message-ID: Subject: Re: [PATCH] KVM: SVM: check CR4 changes against vcpu->arch To: Paolo Bonzini Cc: LKML , kvm list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 10:11 AM Paolo Bonzini wrote: > > Similarly to what vmx/vmx.c does, use vcpu->arch.cr4 to check if CR4 > bits PGE, PKE and OSXSAVE have changed. When switching between VMCB01 > and VMCB02, CPUID has to be adjusted every time if CR4.PKE or CR4.OSXSAVE > change; without this patch, instead, CR4 would be checked against the > previous value for L2 on vmentry, and against the previous value for > L1 on vmexit, and CPUID would not be updated. > > Signed-off-by: Paolo Bonzini Reviewed-by: Jim Mattson