Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 16 Nov 2020 16:24:40 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Ian Rogers <irogers@google.com>
Cc:     Namhyung Kim <namhyung@kernel.org>,
        "Jin, Yao" <yao.jin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel <Linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        "Liang, Kan" <kan.liang@intel.com>, "Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Message-ID: <20201116192440.GC614220@kernel.org>
References: <20201104015102.30363-1-yao.jin@linux.intel.com>
 <20201106030018.GA359712@google.com>
 <93fae76f-ce2b-ab0b-3ae9-cc9a2b4cbaec@linux.intel.com>
 <CAM9d7chhrYh1hmHkw8NKkwEHDoU0q2ArpOj3NGm0_RiQ7eSuxQ@mail.gmail.com>
 <20201116170553.GG509215@kernel.org>
 <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
Precedence: bulk

Em Mon, Nov 16, 2020 at 11:12:30AM -0800, Ian Rogers escreveu:
> On Mon, Nov 16, 2020 at 9:05 AM Arnaldo Carvalho de Melo <acme@kernel.org>
> wrote:
> 
> > Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu:
> > > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@linux.intel.com>
> > wrote:
> > > > >> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> > > > >
> > > > > It seems not applied to acme/perf/core cleanly.
> > > > >
> > > > > Thanks,
> > > > > Namhyung
> > > > >
> > > >
> > > > It seems the patch mail is truncated. :(
> > > >
> > > > I attach the patch file in the mail. Sorry for inconvenience.
> > >
> > > I've checked it fixed the perf test on my laptop (skylake).
> > >
> > > Tested-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Thanks, applied.
> >
> > - Arnaldo
> >
> 
> Nit, as the code is generated, would it be possible to add the commands to
> regenerate it?
> 
> E.g. Using the code in:
> https://github.com/intel/event-converter-for-linux-perf
> And extracted perfmon_server_events_v1.4.tar from:
> https://download.01.org/perfmon/
> run:
> json-to-perf-json.py --outdir tools/perf/pmu-events/arch/arch/x86/sklylakex
> perfmon/SKX/skylakex_core_v1.24.json
 
> Looking at the download.01.org/perfmon json there are files
> like skylakex_fp_arith_inst_v1.24.json, and how these are incorporated into
> these events is less than clear.

You mean change event-converter-for-linux-perf to add this as JSON
comments at the start of the generated files?


- Arnaldo