Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] soc: ti: pruss: Fix wrong check against
 *get_match_data return value
To:     <santosh.shilimkar@oracle.com>,
        Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
        <ssantosh@kernel.org>
CC:     <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <praneeth@ti.com>,
        <tony@atomide.com>, Wei Yongjun <weiyongjun1@huawei.com>
References: <20201116172233.18459-1-grzegorz.jaszczyk@linaro.org>
 <7a18452c-8c9c-df7d-b175-529ab690623f@ti.com>
 <528e56d5-23d5-9f83-1bf4-a7f786593eae@oracle.com>
From:   Suman Anna <s-anna@ti.com>
Message-ID: <af1ecbaf-52e5-5e8b-2b0c-ee8cfe5cb0f0@ti.com>
Date:   Mon, 16 Nov 2020 13:11:57 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <528e56d5-23d5-9f83-1bf4-a7f786593eae@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/16/20 1:06 PM, santosh.shilimkar@oracle.com wrote:
> On 11/16/20 9:31 AM, Suman Anna wrote:
>> Hi Santosh,
>>
>> On 11/16/20 11:22 AM, Grzegorz Jaszczyk wrote:
>>> Since the of_device_get_match_data() doesn't return error code, remove
>>> wrong IS_ERR test. Proper check against NULL pointer is already done
>>> later before usage: if (data && data->...).
>>>
>>> Additionally, proceeding with empty device data is valid (e.g. in case
>>> of "ti,am3356-pruss").
>>>
>>> Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX")
>>> Reported-by: Wei Yongjun <weiyongjun1@huawei.com>
>>> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>>> Acked-by: Suman Anna <s-anna@ti.com>
>>
>> Can you please pick this up for 5.10-rc's?
>>
> Nothing is broken so I will just add these for next merge window.

Yeah, that is fine as well. Thanks Santosh.

regards
Suman