Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3547122pxb; Mon, 16 Nov 2020 18:41:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyf+ZacHUdvTo3w8v8b0nNddH8mZDtW+rUotS2gG6GShuI2CbJxncyzEqTDR2g/K8P2umSE X-Received: by 2002:a17:906:1b09:: with SMTP id o9mr18138464ejg.79.1605580917289; Mon, 16 Nov 2020 18:41:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605580917; cv=none; d=google.com; s=arc-20160816; b=Nzl6EslVFoDuxvZwV1zmlj5yvZIgl/f2xKpAIQObSKDhBk5mXtMXwO8Jfi/ITSY45j OoFVwhK7szgI+LRlKYcIAeps9aDzgGn0j5K0G2vZ865R0HvtTrf2q/hIxMUqDG0vgr/5 GWdnqrxo4huK1DWmzZ8ilRUGhXO4lTMGFVzSLMnrDAv8NYsYbgqaZ/NXvPlNePFPn8W9 zIls1OOaYce3UatVtSFBeDB/lEdinP0y4mbwtGFHy8/KmS64SCxK0f3PUhiZSqq3dpxT tpbRwwqgCcuLWnyAnI4X30JIfkXTP3De0WcCPaHY4hFkjnLRA2atbDE6t7GoFGkBpbdV 5nPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=9H8gke3z9aCWjtIoR37ECAMyQV7JMwqXyeMdMuGFBNI=; b=RQSdcuNQA+lmEyXC8BB7f6aUrXkhNaZrrq9f6SrucjCoehRSoRXvupcZWrI7xu/jry lPVBdChtEGN0N8QNdPSNxr+Yxj5TgfYXkVYzKYXdjE2o14vz6xf/GwEYifBZYNtPU25/ /qTF90XXQj0XvNqiNL+es3arBKebRYZG0S1gCB3X8c6GkEipJeofSNfciE8z7lxWdwVO bKRBXuiSKWUjp6VLV8P7FEu28qRX7mUr533r86lhFgfhjKH8oD9zqk7ZG9C0omFCE9yW C895xUjNzaUgnkE+LBzP2Ho/wy6AFJdMVHkTkCCWFviAKtTfLrN3YYQNmFG07Q7vk6xS 24Gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx24si12850433edb.419.2020.11.16.18.41.35; Mon, 16 Nov 2020 18:41:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbgKQBuL convert rfc822-to-8bit (ORCPT + 99 others); Mon, 16 Nov 2020 20:50:11 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:55329 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgKQBuL (ORCPT ); Mon, 16 Nov 2020 20:50:11 -0500 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 0AH1o4WJ1014800, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmb03.realtek.com.tw[172.21.6.96]) by rtits2.realtek.com.tw (8.15.2/2.70/5.88) with ESMTPS id 0AH1o4WJ1014800 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 17 Nov 2020 09:50:04 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.33) by RTEXMB03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 17 Nov 2020 09:50:03 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 17 Nov 2020 09:50:03 +0800 Received: from RTEXMB04.realtek.com.tw ([fe80::89f7:e6c3:b043:15fa]) by RTEXMB04.realtek.com.tw ([fe80::89f7:e6c3:b043:15fa%3]) with mapi id 15.01.2044.006; Tue, 17 Nov 2020 09:50:03 +0800 From: Hayes Wang To: Jakub Kicinski , Marek Szyprowski CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver Thread-Topic: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver Thread-Index: AQHWu+Uk6MVFESXbN0aOZKSDeZR30KnJ9OqAgACBuYCAARgAcA== Date: Tue, 17 Nov 2020 01:50:03 +0000 Message-ID: <02f38e505a3a45389e2f3c06b2f6c850@realtek.com> References: <7fd014f2-c9a5-e7ec-f1c6-b3e4bb0f6eb6@samsung.com> <1394712342-15778-393-Taiwan-albertk@realtek.com> <5f3db229-940c-c8ed-257b-0b4b3dd2afbb@samsung.com> <20201116090231.423afc8f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201116090231.423afc8f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.146] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski > Sent: Tuesday, November 17, 2020 1:03 AM [...] > > Yes, this fixes this issue, although I would prefer a separate Kconfig > > entry for r8153_ecm with proper dependencies instead of this ifdefs in > > Makefile. > > Agreed, this is what dependency resolution is for. > > Let's just make this a separate Kconfig entry. Excuse me. I am not familiar with Kconfig. I wish r8153_ecm could be used, even CONFIG_USB_RTL8152 is not defined. How should set it in Kconfig? Best Regards, Hayes