Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3547575pxb; Mon, 16 Nov 2020 18:43:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJz73UT0pNeOlFgm0bJ7tsRS2JXNYZHUxU3e9MowwCLksHxpKJf2jynw6wdS/BvpY0r0+kH2 X-Received: by 2002:a17:906:9353:: with SMTP id p19mr25776ejw.17.1605580989349; Mon, 16 Nov 2020 18:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605580989; cv=none; d=google.com; s=arc-20160816; b=J/7wwOgzNvUdqWUTaC5N+Fy+lBNAQ5j8buyva9QBd0Dp6E+4WhJ5V1HLuDMbAX3Glf Y8YIg/ZaI7aiql8deCMlp/ptVM6GzDDguR2vXcnibwbpAszYAzTvDOKrP2ulfZGB/b0H 0p+peSr12y2PYId7RV+Y6SC6lHEbQ7J5dsOe2YYM8uyu1XB9EpV2RDo0a9evkgEhC1Qb 91njOhTTitOOzuVM6JsYWMiPfbo8iv/5JhRLL+PZHwByL599b/n7pC7wfT5gHkkWsBUL PY4m5v0sBsEgP7a+r2obQUqKE4zE6GJkSm56DTJvcetv2cN8P/MjAQ16twuY8ZCJ63iC T2iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=eMaGvad7rhLakuvd4HC4BLI3+8JpBGJjO0TDpzbE9qE=; b=VWzkr7w8v/9lE6545FCVxfBzGv2ornEuzv5fNyiJCdj4YcaHpXuc15HIyVi+VPXCYM Oa+8a+fLa2MYABHeMYhDTjk/d/OxhHGIr5GYjef2i0IaF8wwJBXGUOOLxbJ26fD2C3JD zpSqbFKNFoZf155HXVLZYWRN8ts7fLsvbHv0Pe5fOSMXOfkQYCE/Y2FYyQCE2tDc4dLb 384RQa7ZuNigJmFhIvSpMIJCmTZVFPKjJ6AI1k06qMhetiMteKyhhLTn4NdZ6a3hSyOm smb36xEwDNy7hduVxTShSY92BNgp8fI9vpaLN8FshMb6YAcTaLtKUgJoYJaj7mA6BiCi +XVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be25si13212203edb.288.2020.11.16.18.42.47; Mon, 16 Nov 2020 18:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727288AbgKQCFU (ORCPT + 99 others); Mon, 16 Nov 2020 21:05:20 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59158 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgKQCFU (ORCPT ); Mon, 16 Nov 2020 21:05:20 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1keqMs-007S7z-Jy; Tue, 17 Nov 2020 03:05:14 +0100 Date: Tue, 17 Nov 2020 03:05:14 +0100 From: Andrew Lunn To: Martin Blumenstingl Cc: davem@davemloft.net, kuba@kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, jianxin.pan@amlogic.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khilman@baylibre.com, narmstrong@baylibre.com, jbrunet@baylibre.com, f.fainelli@gmail.com Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function Message-ID: <20201117020514.GD1752213@lunn.ch> References: <20201115185210.573739-1-martin.blumenstingl@googlemail.com> <20201115185210.573739-5-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201115185210.573739-5-martin.blumenstingl@googlemail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 15, 2020 at 07:52:09PM +0100, Martin Blumenstingl wrote: > Newer SoCs starting with the Amlogic Meson G12A have more a precise > RGMII RX delay configuration register. This means more complexity in the > code. Extract the existing RGMII delay configuration code into a > separate function to make it easier to read/understand even when adding > more logic in the future. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Andrew Lunn Andrew