Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3558273pxb;
        Mon, 16 Nov 2020 19:08:43 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzcykeCqiYzBDKShsFFeMvKMZzhJvZfnR0sYY8A/nTCw7KBMM7cO82TnNfAN5/T/Zy8bpQr
X-Received: by 2002:a17:906:198b:: with SMTP id g11mr16808673ejd.445.1605582523399;
        Mon, 16 Nov 2020 19:08:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605582523; cv=none;
        d=google.com; s=arc-20160816;
        b=YEGJaB+23jXueYQCKMqElfqPW+9nKOnWpGN2aAy1nfH0BDYG4IAA8woA6TgYRD7qRM
         tExyM2BswsFG0utuk/huvo93KsY934KQ0oR6S8XYe1fnlSiqtN89tQWJk80uLSm3Cv2B
         m3VJkzIA9NWuWESU8IE0k2Hc+8bc+WBne26eeEUncGhPpvHC0uFTplYbdriePDNT/BlA
         AZLGPdgIe1+Bf5da+QY/MYDaezq2giigO/j1h/A2crjifwqQuKE5YsR2wNbHbiIHCDgY
         +xnE/flvip/rpDCRQrrRAq3EzQXI69m2LIf4y9otC0taByUQX1jQ0a1dABafb2kWG/vQ
         8obw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :mime-version:references:in-reply-to:message-id:date:subject:cc:to
         :from;
        bh=p723JtS1pJNVabNwPxJOJJ9MW40U8eP5btKJWk1846o=;
        b=nuKAKdgoDGqBqLaFHLGArirtNrGz4eBThaQbmH+i5dpQK33XDO7tG52NwxDAlvJzPV
         ozqWycMg29DQKzJNT4PpM1AXolcBJbO5QQqjJUHzerOZs99oO7lHOhHjBeLVAn/9wYxr
         CE80dVmeR1W00MVWwbYHbiXP4lhnnz7cNy35/bihlD+tRes3xLBqE+DiUppJRbL8Bkva
         7iW9GBnCdAQdqMqvnY2xU/sXz/Nopd7VZ2b5XDZJIVCYvmcoGb89eW3O1tFcBkxrDWHl
         MGPHYZJNMvMjyOfu9md0OKSsMG56l0nKQ5DlHLLz1GeMtKneQa6TS2IbWMS6+sK/09Ze
         WGkA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=h6SG+P3f;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h8si13486204edk.97.2020.11.16.19.08.20;
        Mon, 16 Nov 2020 19:08:43 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=h6SG+P3f;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726820AbgKQDEs (ORCPT <rfc822;lunatang2017@gmail.com>
        + 99 others); Mon, 16 Nov 2020 22:04:48 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:16112 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726385AbgKQDEs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Nov 2020 22:04:48 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fb33dd40000>; Mon, 16 Nov 2020 19:04:52 -0800
Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com
 (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Nov
 2020 03:04:43 +0000
Received: from sandstorm.nvidia.com (172.20.13.39) by mail.nvidia.com
 (172.20.187.15) with Microsoft SMTP Server id 15.0.1473.3 via Frontend
 Transport; Tue, 17 Nov 2020 03:04:42 +0000
From:   John Hubbard <jhubbard@nvidia.com>
To:     <jarkko.sakkinen@iki.fi>
CC:     <akpm@linux-foundation.org>, <andreyknvl@google.com>,
        <ast@kernel.org>, <clang-built-linux@googlegroups.com>,
        <daniel@iogearbox.net>, <elver@google.com>, <jarkko@kernel.org>,
        <keescook@chromium.org>, <linux-kernel@vger.kernel.org>,
        <masahiroy@kernel.org>, <miguel.ojeda.sandonis@gmail.com>,
        <natechancellor@gmail.com>, <ndesaulniers@google.com>,
        <sedat.dilek@gmail.com>, <vincenzo.frascino@arm.com>,
        <will@kernel.org>, John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1
Date:   Mon, 16 Nov 2020 19:04:27 -0800
Message-ID: <20201117030427.61981-1-jhubbard@nvidia.com>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201104013447.GA21728@kapsi.fi>
References: <20201104013447.GA21728@kapsi.fi>
MIME-Version: 1.0
X-NVConfidentiality: public
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1605582292; bh=p723JtS1pJNVabNwPxJOJJ9MW40U8eP5btKJWk1846o=;
        h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To:
         References:MIME-Version:X-NVConfidentiality:
         Content-Transfer-Encoding:Content-Type;
        b=h6SG+P3fwWiJQPLj7/ZIQAwecBaI1oNF0DJ6T+ljGCzRXbkm8LFDMApUWRLcoPMqM
         udVkSjFASc2KiIHWG/eQ1cWu99N031pnd49g2iwvmoT6tUAFQ85OpxA1fT7puID4/g
         hyUKn5vjMowxvpworxMFWf+h2EtmA10Cx+H0Ty4UESclYA8iHrOcpV1OQICgELptyJ
         dXo80uKYV69tuxm0SIIro3gd0kgfJwWQiMLTgGkOjSt2xKtk/UBYj/30byeBDz11Zw
         DRfAQwgJOlQGNiBep3Gv5ArmOAuok6zr62JLwKVRl08LHBJRX2yJWoDFlGMoDt5asd
         B0BPpzS6Ys/TQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

I just ran into this and it's a real pain to figure out, because even
with the very latest Fedora 33 on my test machine, which provides clang
version 11.0.0:

$ clang --version
clang version 11.0.0 (Fedora 11.0.0-2.fc33)
Target: x86_64-unknown-linux-gnu

...the bpftrace program still chokes on some, but not all commands, in
ways that invisible to normal debugging. For example:

$ sudo bpftrace -e 'tracepoint:syscalls:sys_enter_vmsplice { @[kstack()]
=3D count(); }'
/lib/modules/5.10.0-rc4-hubbard-github+/source/include/linux/compiler-clang=
.h:12:3:
error: Sorry, your version of Clang is too old - please use 10.0.1 or
newer.

But Jarkko's recommended fix works! In other words, applying the diff
below fixes it for me. So I'm replying in order to note that the problem
is real and hoping that the fix is applied soon.


diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.=
h
index dd7233c48bf3..c2228b957fd7 100644
--- a/include/linux/compiler-clang.h
+++ b/include/linux/compiler-clang.h
@@ -7,9 +7,11 @@
 		     + __clang_minor__ * 100	\
 		     + __clang_patchlevel__)
=20
+#ifndef __BPF_TRACING__
 #if CLANG_VERSION < 100001
 # error Sorry, your version of Clang is too old - please use 10.0.1 or new=
er.
 #endif
+#endif
=20
 /* Compiler specific definitions for Clang compiler */
=20


thanks,
--
John Hubbard
NVIDIA