Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e18107c14e59672a179b4fe4d9918c311c0aa9e9.camel@decadent.org.uk>
Subject: Re: drivers/accessibility/speakup/serialio.c:48:19: warning:
 variable 'quot' set but not used
From:   Ben Hutchings <ben@decadent.org.uk>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Mon, 16 Nov 2020 20:39:02 +0000
In-Reply-To: <20201116203355.t7dboh6vlj57dsau@function>
References: <202011160942.AmYkxiJv-lkp@intel.com>
         <20201116190122.yslib3wicn45rbuo@function>
         <ef625c1e21c492be8c423730e45e90d92b1ae899.camel@decadent.org.uk>
         <20201116203355.t7dboh6vlj57dsau@function>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-zO1q+N+/584fGk3wK6e5"
User-Agent: Evolution 3.36.4-2 
MIME-Version: 1.0
Precedence: bulk


--=-zO1q+N+/584fGk3wK6e5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-11-16 at 21:33 +0100, Samuel Thibault wrote:
> Ben Hutchings, le lun. 16 nov. 2020 19:51:23 +0000, a ecrit:
> > On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote:
> > > Perhaps we should rather use
> > >=20
> > > depends on ISA || (X86 && COMPILE_TEST)
> > >=20
> > > ?
> > > so that we have compile testing on x86 only (where the inb/outb macro=
s
> > > always behave fine) to avoid such issues on other archs?
> >=20
> > That seems reasonable though unusual.
> >=20
> > > Or we tell the architecture maintainers to fix their out macros into
> > > consuming their parameters?
> > [...]
> >=20
> > It does seem odd for parisc to define the I/O functions this way.  I
> > don't know if it's really a bug.
>=20
> Sorry I wasn't clear: the problem here is when CONFIG_EISA is disabled,
> the eisa_in/out calls are replaced by BUG() stubs, and the stubs do not
> consume their input:

Yes, I did see that.

Ben.

> arch/parisc/include/asm/io.h
>=20
> #if defined(CONFIG_PCI)
> extern void outb(unsigned char b, int addr);
> #elif defined(CONFIG_EISA)
> #define outb eisa_out8
> #else
> #define outb(x, y)	BUG()
> #endif
>=20
> Samuel
--=20
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                      - Albert Einstein


--=-zO1q+N+/584fGk3wK6e5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAl+y42YACgkQ57/I7JWG
EQmeKQ/9HnaPJllzRlnZauq0VVAeVVEBvs6IHY4eVoOhRKITK2xyfu1bNLzTXXH+
gQv0rFWaGz6ebtfujeyqYE3irQohX4o1EUTxypQPUWhBCg4Isg19DpYohWguZabd
LURJWKjgiFCHC28+2qnW4uzoV7psQ6XmWOwcUlaEIEjJ+4AUBeM3mCA2hIfBDjty
J7EHM/x+oyMp/aWj2avUcLDP7sOANzkw6QJHUSvA1RHFS3gTlVAz6ubHkKUyXB8m
2BYd27AZpqq8DCCOf5KURRR1/TUEIwsYU8HyOsx8NL+jKQ3jA5m9qFpgAIOfMj8e
dc9kNSgLS6daIgyvhr6yO9lKO5V3VQpKbFEA+vhByko8w+2pAmI09e8+75PMlmDb
TnINz37PE0kD1DoRVw/ohKtQe8Dv8gJXxNR+SP7u/EbSOf34iH3GaaDmZ8ZFW8Zp
exsBnXrEt4KgbrXNxLP74nHMgeZtPb3g9LOMk2SDp09uj+GWLzLdk/Jk2tiIAQeF
gp+x+ViVaHXGjBkIqtZ8rG/wSKb/2/GuKlpjdr1PJRTtRz+jQRn+k7VbI5hG0EU/
IKwbCfKtewUvQeo37fkaNQi9PVke4EqksSaPEjutlh05lSrWeXRuSWBKZspCalNs
t43/PgxCQAXq58m3itcc5cPHu3GyQD8yLx/rxKRSX+m2/mHnuJs=
=Bw8u
-----END PGP SIGNATURE-----

--=-zO1q+N+/584fGk3wK6e5--