Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] btrfs: remove the useless value assignment in
 block_rsv_release_bytes
To:     dsterba@suse.cz, dsterba@suse.com
References: <1605422363-14947-1-git-send-email-kaixuxia@tencent.com>
 <20201116151512.GJ6756@twin.jikos.cz>
From:   kaixuxia <xiakaixu1987@gmail.com>
Cc:     clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Message-ID: <104c5965-fbbe-b306-e835-5f2bbf60aa7f@gmail.com>
Date:   Tue, 17 Nov 2020 11:17:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201116151512.GJ6756@twin.jikos.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/11/16 23:15, David Sterba wrote:
> On Sun, Nov 15, 2020 at 02:39:23PM +0800, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> The variable qgroup_to_release is overwritten by the following if/else
>> statement before it is used, so this assignment is useless. Remove it.
> 
> Again this lacks explanation why removing it is correct.
> 
Actually this assignment is redundant because the variable qgroup_to_release
has been overwritten before it is used. The logic like this,

 static u64 block_rsv_release_bytes(...)
 {
 ...
        if (num_bytes == (u64)-1) {
                num_bytes = block_rsv->size;
                qgroup_to_release = block_rsv->qgroup_rsv_size;
        }   
        
	//qgroup_to_release isn't used

        if (block_rsv->qgroup_rsv_reserved >= block_rsv->qgroup_rsv_size) {
                qgroup_to_release = block_rsv->qgroup_rsv_reserved -
                                    block_rsv->qgroup_rsv_size;
                block_rsv->qgroup_rsv_reserved = block_rsv->qgroup_rsv_size;
        } else {
                qgroup_to_release = 0;
        }//qgroup_to_release is overwritten    
 ...
 }

Thanks,
Kaixu

-- 
kaixuxia