Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113113451.52355-1-zhang.lyra@gmail.com> <20201113113451.52355-2-zhang.lyra@gmail.com>
 <20201116145444.GA1635499@bogus>
In-Reply-To: <20201116145444.GA1635499@bogus>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Tue, 17 Nov 2020 11:34:28 +0800
Message-ID: <CAAfSe-tgX=ajiUeZ+4Kp5HG95OUJz573Fj9pw2suLqQp89AeRg@mail.gmail.com>
Subject: Re: [PATCH 2/3] dt-bindings: input: Convert sc27xx-vibra.txt to json-schema
To:     Rob Herring <robh@kernel.org>
Cc:     Orson Zhai <orsonzhai@gmail.com>, linux-input@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Nemo Han <nemo.han@unisoc.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 16 Nov 2020 at 22:54, Rob Herring <robh@kernel.org> wrote:
>
> On Fri, 13 Nov 2020 19:34:50 +0800, Chunyan Zhang wrote:
> > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> >
> > Convert the sprd sc27xx vibrator binding to DT schema using json-schema.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> >  .../bindings/input/sprd,sc27xx-vibra.txt      | 23 ----------
> >  .../bindings/input/sprd,sc27xx-vibrator.yaml  | 44 +++++++++++++++++++
> >  2 files changed, 44 insertions(+), 23 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/input/sprd,sc27xx-vibra.txt
> >  create mode 100644 Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml: 'additionalProperties' is a required property
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml: ignoring, error in schema:
> warning: no schema found in file: ./Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
>
>
> See https://patchwork.ozlabs.org/patch/1399724
>
> The base for the patch is generally the last rc1. Any dependencies

When trying to reproduce the error, I found there's an error on rc1
along with a lot of unrelated warnings, but rc2 is good.

$ make -k dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
  LINT    Documentation/devicetree/bindings

[snip...]

make[1]: *** [Documentation/devicetree/bindings/Makefile:59:
Documentation/devicetree/bindings/processed-schema-examples.json]
Error 123
  DTEX    Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dts
make[1]: Target '__build' not remade because of errors.
make: *** [Makefile:1364: dt_binding_check] Error 2

> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.

Ok, thanks for pointing this out.

Chunyan