Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: q/XLf/syn0pkLSChM1xhZkMf8uWsw47gVT5B5twViLsomDWgmx/aX0S7FJxhMvU6WWmF0S7Hih
 ZE56prMT8IHQ==
IronPort-SDR: OJyEAJwupTcejrNgP+arSDCBG3RV0nzIt3rzpr4dk9U72ehub4eMTKsIRitC5+hhJHKjPzP6f3
 MCebQDWd9zZA==
Message-ID: <4e28affd89ba8a852e0fb7ace076458b3d43839a.camel@intel.com>
Subject: Re: [PATCH] thermal: Fix NULL pointer dereference issue
From:   Zhang Rui <rui.zhang@intel.com>
To:     Mukesh Ojha <mojha@codeaurora.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     daniel.lezcano@linaro.org, amitk@kernel.org
Date:   Tue, 17 Nov 2020 15:18:57 +0800
In-Reply-To: <1605544181-5348-1-git-send-email-mojha@codeaurora.org>
References: <1605544181-5348-1-git-send-email-mojha@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-11-16 at 21:59 +0530, Mukesh Ojha wrote:
> Cooling stats variable inside thermal_cooling_device_stats_update()
> can get NULL. We should add a NULL check on stat inside for sanity.
> 
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
>  drivers/thermal/thermal_sysfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/thermal/thermal_sysfs.c
> b/drivers/thermal/thermal_sysfs.c
> index a6f371f..f52708f 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -754,6 +754,9 @@ void thermal_cooling_device_stats_update(struct
> thermal_cooling_device *cdev,
>  {
>  	struct cooling_dev_stats *stats = cdev->stats;
>  
> +	if (!stats)
> +		return;
> +
May I know in which case stats can be NULL?
The only possibility I can see is that cdev->ops->get_max_state() fails
in cooling_device_stats_setup(), right?

thanks,
rui

>  	spin_lock(&stats->lock);
>  
>  	if (stats->state == new_state)