Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3693107pxb; Tue, 17 Nov 2020 00:37:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhUJdQRoivzUygmmDToIs8HZo38mQww13Bht4ZAfFa3CXot7E8ItQvS3f8NLU4xGPEexn0 X-Received: by 2002:a17:906:b53:: with SMTP id v19mr17747923ejg.136.1605602274154; Tue, 17 Nov 2020 00:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605602274; cv=none; d=google.com; s=arc-20160816; b=0uYlC0u3UWcxR/3nIfV174RJf7RHWgZCkL3X65dVsjuJZVl3cmpHWOHFKAUPVQ9qmH M5RzU1lev7dKQJUHF9UJorbpiCZX7ECezvKuZMSMMgSp3Cd/0b4LeZmnLRP+rONA8NPE /O0BuY5xbiIvOA1xgvgV66sd7PQigQMFM8tTSlXjTDIb0F/VsJv5fMMOfNz5bX0Dhgx4 cn8hs4fa+hAyyGFHTW0k8gQZWO2Lb55uuosvE9C22lx4ZSrh3ec2porLQy1LfQx9eRv8 GLpdRAJkvKhlnqaJw5yq2mtg/dvwjuDvNWg+q+qxLsnnsj7vGhSTT4hUi2uLEA2S+5LJ ONXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:from:references:cc:to:subject:dkim-signature; bh=roGP5mtDqxI55hJ9MkwC62bf62HGkGdNDSySlnX36OM=; b=S39iDsTH29Ek+4zeSsG4z4q3lM4DrzJCmFsF3APafOEjG2XkRpK9nxf5a7UzzvsGVT CQ7aVT5kd0H7DdosPCKjlKHwWtVfcq00l0csXFB0ntKHgGaJy0LZwuvCMjayHve9Z71C wI+rX2N6EtfoJiqentrHFaKWLH4dt+045JunTmsksP3nQY+YqEj0iE22vZfIa81FVroP LBZMMZRZcvHL9JRxmovH0FWqCw7rUcuPFmI/fXnqcq3lJtT3DmQW7+tKjjGDtL4qnmD8 VjhRTIq+dJFWc9p5f/MhjIBIn4y5tG3D3cUVmi3ZxuLqd3OLG5DOXw0xlGbrGL7xpB3B U7rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iMaclrlJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gb40si12645325ejc.506.2020.11.17.00.37.30; Tue, 17 Nov 2020 00:37:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iMaclrlJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgKQIe5 (ORCPT + 99 others); Tue, 17 Nov 2020 03:34:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgKQIe4 (ORCPT ); Tue, 17 Nov 2020 03:34:56 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A4FC0613CF for ; Tue, 17 Nov 2020 00:34:54 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id w24so2413055wmi.0 for ; Tue, 17 Nov 2020 00:34:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=roGP5mtDqxI55hJ9MkwC62bf62HGkGdNDSySlnX36OM=; b=iMaclrlJcxiJUoYxefxENfVZ/ZNa4XC9/VKom3TB9qm9jUi8YbdgDEwDgOpDVUgwJp fMrpl0ekb6HuHzPeqcT2ZgTnh21ufegEUYoU0pvIheDgyZNxus7oHz3emomHkgxM1KH5 068KKMZithkH/BwyXD1N2vp4oLLZ0+OtIAaC4jZpon3ERk8pvDmLsiBvqrmh5k0sxXlf Tq4UcXPFWTsveNVukx7ze77ONjF/FBdhCrsNmm/QL8z36YYl70gbjPQoXQ473LH9Uwyb vXC+4Syi1rl6V/vctwX5H8wcJcXtGKPHDAHkK9JTFoRKJjuCU/xe+dX0MVAZD52bQU8v ImFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=roGP5mtDqxI55hJ9MkwC62bf62HGkGdNDSySlnX36OM=; b=cCZYBOC1kt61M/Wv38DT/sV3GYR9TLNlV5GJWjyocSYDoCY/IpnxJs934Y9Q8U6VjV 0rLC23uHPcMs/P/fwInY6vPJQlYz4Z1KA+JHqSATSlwxG9zK+gRrV/o4qPrCCgbl39+X 8gxG2qpaZm56tAGk93MQJLM1TX+6WpAPvU1AdXFCofiCD90xZvlCq2mBAa5lSE5fkSAQ U6GIMUGwOrDd/4lrAFF4slmgF2Ojf8zzU6VcGY5BIUXVltthsol1PgQOatNlUqiA0b02 DkBA6ffaPqibwFgBGZXBHia8mP5a/nTczfU5yDpVPi+XOf8d5DKvhg4LtZTHuMCB4oG+ yaGQ== X-Gm-Message-State: AOAM530IkKt682L8X8U7qp2ll05vIMpv2AC5pj3bOj7IVuHXMlOw1ooG XA/AAQfCxIKiOFZgFLPL43wY2A== X-Received: by 2002:a7b:cb13:: with SMTP id u19mr3054777wmj.89.1605602093397; Tue, 17 Nov 2020 00:34:53 -0800 (PST) Received: from ?IPv6:2a01:e35:2ec0:82b0:1561:9f4b:5829:8e26? ([2a01:e35:2ec0:82b0:1561:9f4b:5829:8e26]) by smtp.gmail.com with ESMTPSA id s188sm2462816wmf.45.2020.11.17.00.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 00:34:52 -0800 (PST) Subject: Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get() To: Yejune Deng , kishon@ti.com, vkoul@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, p.zabel@pengutronix.de Cc: lorenzo.pieralisi@arm.com, repk@triplefau.lt, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org References: <1605592689-10108-1-git-send-email-yejune.deng@gmail.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <9be419cc-ffbf-c260-e804-bc29887781ed@baylibre.com> Date: Tue, 17 Nov 2020 09:34:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1605592689-10108-1-git-send-email-yejune.deng@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/11/2020 06:58, Yejune Deng wrote: > devm_reset_control_array_get_exclusive() looks more readable > > Signed-off-by: Yejune Deng > --- > drivers/phy/amlogic/phy-meson-axg-pcie.c | 2 +- > drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +- > drivers/soc/amlogic/meson-ee-pwrc.c | 3 +-- > drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +- > 4 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c > index 377ed0d..3204f02 100644 > --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c > +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c > @@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) > if (IS_ERR(priv->regmap)) > return PTR_ERR(priv->regmap); > > - priv->reset = devm_reset_control_array_get(dev, false, false); > + priv->reset = devm_reset_control_array_get_exclusive(dev); > if (IS_ERR(priv->reset)) > return PTR_ERR(priv->reset); > > diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c > index 08e3227..bab6345 100644 > --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c > +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c > @@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev) > if (ret) > goto err_disable_clk_ref; > > - priv->reset = devm_reset_control_array_get(dev, false, false); > + priv->reset = devm_reset_control_array_get_exclusive(dev); > if (IS_ERR(priv->reset)) > return PTR_ERR(priv->reset); > > diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c > index ed7d2fb..3a879a4 100644 > --- a/drivers/soc/amlogic/meson-ee-pwrc.c > +++ b/drivers/soc/amlogic/meson-ee-pwrc.c > @@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev, > dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n", > count, dom->desc.name); > > - dom->rstc = devm_reset_control_array_get(&pdev->dev, false, > - false); > + dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev); > if (IS_ERR(dom->rstc)) > return PTR_ERR(dom->rstc); > } > diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > index 8790627..b4615b2 100644 > --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > @@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) > return PTR_ERR(regmap_hhi); > } > > - rstc = devm_reset_control_array_get(&pdev->dev, false, false); > + rstc = devm_reset_control_array_get_exclusive(&pdev->dev); > if (IS_ERR(rstc)) { > if (PTR_ERR(rstc) != -EPROBE_DEFER) > dev_err(&pdev->dev, "failed to get reset lines\n"); > Reviewed-by: Neil Armstrong