Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5cLWV8aVxJr1wx73M7yifHYrpfjBzwjJ0efANfihBlp4uG8uRr3Kwz4J4rLGPHwjvl2PuTl6ne
 P6SXBCAzxjww==
IronPort-SDR: dG1ny2XRRY/+PJJPjr68EMmoLNYp7HC3dGGtUVrmxGNxJadnv2NJr5ZmpnPZ5JCtnw3qcgPK+G
 4sglLFud5/AA==
Message-ID: <fd11744b16a91428303fe848ef8f72fd8f5c9a5e.camel@intel.com>
Subject: Re: [PATCH] thermal: Fix NULL pointer dereference issue
From:   Zhang Rui <rui.zhang@intel.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Mukesh Ojha <mojha@codeaurora.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     amitk@kernel.org
Date:   Tue, 17 Nov 2020 19:27:47 +0800
In-Reply-To: <f8c436ae-0f4c-5d2e-51a8-0e856fbf8f44@linaro.org>
References: <1605544181-5348-1-git-send-email-mojha@codeaurora.org>
         <4e28affd89ba8a852e0fb7ace076458b3d43839a.camel@intel.com>
         <f8c436ae-0f4c-5d2e-51a8-0e856fbf8f44@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2020-11-17 at 09:57 +0100, Daniel Lezcano wrote:
> On 17/11/2020 08:18, Zhang Rui wrote:
> > On Mon, 2020-11-16 at 21:59 +0530, Mukesh Ojha wrote:
> > > Cooling stats variable inside
> > > thermal_cooling_device_stats_update()
> > > can get NULL. We should add a NULL check on stat inside for
> > > sanity.
> > > 
> > > Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> > > ---
> > >  drivers/thermal/thermal_sysfs.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/thermal/thermal_sysfs.c
> > > b/drivers/thermal/thermal_sysfs.c
> > > index a6f371f..f52708f 100644
> > > --- a/drivers/thermal/thermal_sysfs.c
> > > +++ b/drivers/thermal/thermal_sysfs.c
> > > @@ -754,6 +754,9 @@ void
> > > thermal_cooling_device_stats_update(struct
> > > thermal_cooling_device *cdev,
> > >  {
> > >  	struct cooling_dev_stats *stats = cdev->stats;
> > >  
> > > +	if (!stats)
> > > +		return;
> > > +
> > 
> > May I know in which case stats can be NULL?
> > The only possibility I can see is that cdev->ops->get_max_state()
> > fails
> > in cooling_device_stats_setup(), right?
> 
> A few lines below, the allocation could fail.
> 
>         stats = kzalloc(var, GFP_KERNEL);
>         if (!stats)
>                 return;
> 
> Some drivers define themselves as a cooling device state to let the
> userspace to act on their power. The screen brightness is one example
> with a cdev with 1024 states, the resulting stats table to be
> allocated
> is very big and the kzalloc is prone to fail.
> 
Oh, right.
As we're not going to fix the cdev, so I think we do need this patch,
right?

thanks,
rui
> > thanks,
> > rui
> > 
> > >  	spin_lock(&stats->lock);
> > >  
> > >  	if (stats->state == new_state)
> 
>