Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1604888706-63429-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1604888706-63429-1-git-send-email-zou_wei@huawei.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 17 Nov 2020 12:49:47 +0100
Message-ID: <CAPDyKFr84zM8fu5KjHNWSQr4KyBVojbgDq82x_g90-VrFQiYLw@mail.gmail.com>
Subject: Re: [PATCH -next] mmc: owl-mmc: use true and false for bool variables
To:     Zou Wei <zou_wei@huawei.com>
Cc:     =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 9 Nov 2020 at 03:13, Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix coccicheck warnings:
>
> ./owl-mmc.c:524:2-18: WARNING: Assignment of 0/1 to bool variable
> ./owl-mmc.c:528:2-18: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/owl-mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 82d2bad..53b81582 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -521,11 +521,11 @@ static void owl_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
>         /* Enable DDR mode if requested */
>         if (ios->timing == MMC_TIMING_UHS_DDR50) {
> -               owl_host->ddr_50 = 1;
> +               owl_host->ddr_50 = true;
>                 owl_mmc_update_reg(owl_host->base + OWL_REG_SD_EN,
>                                OWL_SD_EN_DDREN, true);
>         } else {
> -               owl_host->ddr_50 = 0;
> +               owl_host->ddr_50 = false;
>         }
>  }
>
> --
> 2.6.2
>