Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3808012pxb; Tue, 17 Nov 2020 04:13:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5f9vOMFbgl3EwZcQoUeTcsG2vvGqicGYxzkJThSrACcN3RVAUK90+IREQFJO1NCciwf9b X-Received: by 2002:a17:906:50e:: with SMTP id j14mr18986071eja.403.1605615230208; Tue, 17 Nov 2020 04:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605615230; cv=none; d=google.com; s=arc-20160816; b=JHQL9ufP8FM+Xvuj8uA4jkfZP/aVjcykQ22qlVPx+mwlK5IElbL8CrME4lI9jl+JPi OnfiqoN6AHpvPBRw9RHE2iKmYU+jmytfzPSD3Wwo9FpBap2QYhCr6W4i7hUfcUwm2bnI 3FANxkN8y+Tm6Wn06xDAw2RMYsfa/n7xFRvADbd/7R9sqaegtb5rC//gnjkG5csJyE47 /Z+09T9f7yG/CrxNH9g3r03fU43qnE/0lnu1pgEzYcc0c7P2qiwRWhSXNOSpK3pZmWmS U6LMTtCd5eKHRnQ68d8tzTV80q/7qX9oE0vchEYRbk/yAFGKJqTjW1XP0TEx37tIAgX2 tI8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5o0jeVSQmzUAmk1xbEshzaNLz0SjmeOddDRU/spmatk=; b=lqNKMzM7qx0sD1qbSCvMDJ4C6zgANbafSJU2yoDJQ25+bkTcqPPJZgSyHjmTjjUrtk AXdo86CbEPziWmFjKqshrD/2boXfXTdEH25FtCoqc/Lsmbfm2VrTkj5ciw4JUfKF8q33 +CYR0Y0mZD+rKScNIEK23e1EhPojQ/62a+Ei4n6sjW+8NmMN3lh/D8Ikt0jutAchlZ4O ZrWN9YUtFRFkbc6jlBDFXVm6of55211xZSDjIkadGJgHGElaG/BeKaSWbcKrNDmjEpoh xvzsUH3lk0mw4/LTHnL5Im+gZj9kmL8Q3ChwCPUgATK/bYSbB6cG+TYgZj34+DjnSD1E AvpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="qjxtY4L/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si4733106edu.349.2020.11.17.04.13.27; Tue, 17 Nov 2020 04:13:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="qjxtY4L/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbgKQMKZ (ORCPT + 99 others); Tue, 17 Nov 2020 07:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgKQMKY (ORCPT ); Tue, 17 Nov 2020 07:10:24 -0500 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43EB0C0613CF for ; Tue, 17 Nov 2020 04:10:23 -0800 (PST) Received: by mail-qk1-x744.google.com with SMTP id v143so20082116qkb.2 for ; Tue, 17 Nov 2020 04:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5o0jeVSQmzUAmk1xbEshzaNLz0SjmeOddDRU/spmatk=; b=qjxtY4L/pSZsKkQwzyQ6WPWLgfbeHzjz9s4p4X2Gvs722PBi6eL1lpTiMJBzQ/va/n 5ZlaCxDNa9s/U8dqmLJm27888YvgtSPNwjbIn5lrebZu+w4S9cZrMb/JhhYiglVlqdyt P+TJNudUVjahKiRKQVMCmAHhSNdHt/BGcbFzjqsWOhnYGc9d5UIfhWUZORc8l2WZLsWM c+JWjM6u7kePTGWtkh7shVB9PcMLCoiGRP5KDTa5p+HhncjRFxmWx0JGuweIqi97nW3I qZQrINX0bHF7JgnrIUv309t0mFZbMeex58hGvdWWJ5mFL3Lx9dTxHzpdOo7fK6EKL6dH NCHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5o0jeVSQmzUAmk1xbEshzaNLz0SjmeOddDRU/spmatk=; b=eI/7w1RvubqSd0xLgFTr0TbsEzKDQRpCEqi7bMOIFB9FWYmn2Tfwm/OIbvQHTGCMIa LWiHNm5J/mZv+pPqngn7K5DNtAOJDYooUr0QbeWsoonwbZ5BUOAzaM0sAzXUCpE7tnGH 3jmnsuBAnKi9EcpZfxHVWgXTOKxChKPM8pS3eXsGCIwNRxfZMK4kZT2XxJ7H66EWWdum 811mTZ2MlKN6TKmHK9DWWTnJ416aCDoJH8p9q0fQKX8omx1YakW7QMbZfQmMmGgRdCGk jOHN9kotpLr3cqsUxA/zfQjHrjFblJ1GQ4g+ZyCun00Z9j25l6KMuvYY2+6Bijla8kRW JuEQ== X-Gm-Message-State: AOAM530Ou8SoqX9bVZ/7FSxAuvdHOLA7TsLlxnCAAuqohoaPlqRg8bXX 06kXTKwkLxSlRj0DSL4quyx3ScgN5uyoBCxLTBgPWfQDkzc= X-Received: by 2002:ae9:f715:: with SMTP id s21mr18936312qkg.467.1605615022569; Tue, 17 Nov 2020 04:10:22 -0800 (PST) MIME-Version: 1.0 References: <160560676899.144950.4148778261999789656.stgit@devnote2> <160560677952.144950.8229834525319742454.stgit@devnote2> In-Reply-To: <160560677952.144950.8229834525319742454.stgit@devnote2> From: Chen Yu Date: Tue, 17 Nov 2020 20:10:10 +0800 Message-ID: Subject: Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly To: Masami Hiramatsu Cc: Steven Rostedt , Linus Torvalds , Chen Yu , LKML , Ingo Molnar , Jonathan Corbet Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 5:53 PM Masami Hiramatsu wrote: > > Fix to check the write(2) failure including partial write > correctly and try to rollback the partial write, because > if there is no BOOTCONFIG_MAGIC string, we can not remove it. > > Fixes: 85c46b78da58 ("bootconfig: Add bootconfig magic word for indicating bootconfig explicitly") > Suggested-by: Linus Torvalds > Signed-off-by: Masami Hiramatsu For [1/3] and [2/3] Tested-by: Chen Yu -- Thanks, Chenyu