Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3848089pxb; Tue, 17 Nov 2020 05:18:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxK8FfMrugpAYmoMbuVEgek/UoZC0pU8i112voXaCU8xv/IJRQ24j3wKDVa9GG9u30/TS7o X-Received: by 2002:a17:906:7e43:: with SMTP id z3mr19929391ejr.143.1605619135450; Tue, 17 Nov 2020 05:18:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605619135; cv=none; d=google.com; s=arc-20160816; b=vHfD76ZAbovs6yFlezStO7HEQ1lkM+bl5zN/GfBnRGkKfhIIInF1BQCDQeBoIEolZZ MKX455BtP086qOmelSb1I2cLFC5xTA55VWCFFw24zWQft1aZNzpmw+Fl4tVE7wV9J361 8lMfoClHW6Xeh9h2hEnvZA41sCyrkBdj8PsLzjGatCeln1RE+16TZwiqP0efOhxMFy64 EdGcW5TqJLqvSpqbYE6k5FpNNm5o1kx/Ouv/YYsDnzLdgnkLgWvRYPcEmYecshF2MDcG u7zfjEnQjtnbthg5lmd43V5ipCkw/H2HuvYCwGvX/oa8BR+QbCC7OXHdZZ6226i1ubR6 M5gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NZRrHH8K2bEHEC4a+tB6N/fq8gG+I38ysLFz2AOgP60=; b=DsClMA28yK/7G6ARlISP14LMqKsE1ywoCAQaoazGl28NNiHqI0Pgbl6YgzNB9ab0VZ dkxA0vYhvoSeFR3oY6XOIUqOGaUww9st1zKljtp968fU1KdJLVwfrq9dmtntFQpB5Wbb n1VnW7mKgjHvJW66/fhB54B/e5hBJtBCjl2GTd8Z4U2Wbdj9LjIz/N8nclkMCyc54Mkj 8oeaHGZmt06lmcWmOS3fZ5LyvPmg3h4U2nZRJNmhhOwUDrdJ8NknF0Haqk5RKVP1gcIf tDKQ6yIcUirckneF1PRHPMaoyXmI0ywE6EfcrHbIQ6Hh4+Ms+CVXD6VgWB003iLbhJto BYxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=P3gBbiSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si13036136eje.644.2020.11.17.05.18.32; Tue, 17 Nov 2020 05:18:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=P3gBbiSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbgKQNOV (ORCPT + 99 others); Tue, 17 Nov 2020 08:14:21 -0500 Received: from mail.skyhub.de ([5.9.137.197]:60094 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730014AbgKQNOJ (ORCPT ); Tue, 17 Nov 2020 08:14:09 -0500 Received: from zn.tnic (p200300ec2f101300ba25257689a011f5.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:1300:ba25:2576:89a0:11f5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 391221EC03CE; Tue, 17 Nov 2020 14:14:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1605618847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=NZRrHH8K2bEHEC4a+tB6N/fq8gG+I38ysLFz2AOgP60=; b=P3gBbiSSrXE9y0CZO80SkiKExytqj+588g+/N4mZLLRjyWaKBGnaPDQihqm1uznAEIMsip 0OdpSRCD3AqRAKTdptQfrZliOls4g7v7kCCsIVDt0uGMfg0Zhpc8sX79DS3XtfAQbCozLh dY/F9hAlqzUV8icvIlPInw5S3CALVXE= Date: Tue, 17 Nov 2020 14:14:02 +0100 From: Borislav Petkov To: Jarkko Sakkinen Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , Andy Lutomirski , Jethro Beekman , Cedric Xing , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v41 19/24] x86/vdso: Implement a vDSO for Intel SGX enclave call Message-ID: <20201117131402.GD5719@zn.tnic> References: <20201112220135.165028-1-jarkko@kernel.org> <20201112220135.165028-20-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201112220135.165028-20-jarkko@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 12:01:30AM +0200, Jarkko Sakkinen wrote: > diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile > index 2ad757fb3c23..9915fbd34264 100644 > --- a/arch/x86/entry/vdso/Makefile > +++ b/arch/x86/entry/vdso/Makefile > @@ -27,6 +27,7 @@ VDSO32-$(CONFIG_IA32_EMULATION) := y > vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o > vobjs32-y := vdso32/note.o vdso32/system_call.o vdso32/sigreturn.o > vobjs32-y += vdso32/vclock_gettime.o > +vobjs-$(VDSO64-y) += vsgx.o Why? This needs to be CONFIG_X86_SGX as you need this vdso functionality only when SGX is enabled. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette