Message-ID: <44EC6360.9070109@trash.net>
Date: Wed, 23 Aug 2006 16:17:04 +0200
From: Patrick McHardy <kaber@trash.net>
User-Agent: Debian Thunderbird 1.0.7 (X11/20051019)
MIME-Version: 1.0
To: James Morris <jmorris@namei.org>
CC: Akinobu Mita <mita@miraclelinux.com>, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
       akpm@osdl.org
Subject: Re: call panic if nl_table allocation fails
References: <20060823113740.GA7834@miraclelinux.com> <Pine.LNX.4.64.0608231003340.3198@d.namei>
In-Reply-To: <Pine.LNX.4.64.0608231003340.3198@d.namei>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 913
Lines: 25

James Morris wrote:
> On Wed, 23 Aug 2006, Akinobu Mita wrote:
> 
> 
>>This patch makes crash happen if initialization of nl_table fails
>>in initcalls. It is better than getting use after free crash later.
> 
> 
>> 	nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL);
> 
> 
> Perhaps it'd be better to declare this as an array rather than allocating 
> it at runtime.

That would still leave the MAX_LINKS allocations for the pid hashes
which need to be allocated because they are dynamically sized. We
could delay the pid hash allocations until the first bind happens
of course, but I doubt it would be worth it since they start with
just a single bucket.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/