Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3862519pxb; Tue, 17 Nov 2020 05:39:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQom/3KFHrenXrXBHyWXRwGKmmwv8lRy5QmLJJeV25RV6RY9ih8tm1/USm2bEns4m+Lp0j X-Received: by 2002:aa7:de01:: with SMTP id h1mr20520974edv.269.1605620380887; Tue, 17 Nov 2020 05:39:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605620380; cv=none; d=google.com; s=arc-20160816; b=FbsZxl0zkQWI5ozN6Y9Il8+f84JvL78Hymld9A+cJEzE/yTn/GN02mfftiflD/FYHL QfQlpmNtpY6T7xTNBjGxoTQ58GEojiCNMHD1oU3IFprSWdN9MDRwkIxstcvA17GYkChN KVLBaV/ZGS3pVOejkdjGGVoS+tr6iKdANuh+k39rfs9AtRJZpPTLWXqqz31wG8Zl0I22 OFlNjUdDf03mttECvY0kpPUdEyKbS7KPohQbR5PTkZViMepjlIVAhGMupnQKcfSi+0IU D90fYXC/otQplvTTqhT5GX+hnMgA0vUnmmgb2sfc6BfAmaJa1jMGemW7CjpIZvBn6UA3 oQEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=STL6UIR5EvjFFmE3tM3/LkntwML7mOCJKvxBoHXy33E=; b=NHbhszmYd38zvEgLzCViufd/YgXMTgjWTcDkzcnNfB4kY73pNfCfcr5c4+l/VA9ZmU pvLucbzwRzBg6Pc/t8UAmuV7SO+SGYczSSxbqa2lwXNJhC71tdqml2nMG6+9HN1JEgT1 jp7wtOLwS0ue+ii1ts+s2iAPDKHyei4bknBKqaGLQHeXpTBwj5D24qc4lrGudAiM9TXX 0RkTxil6Li0xxZfw4iMoLEF8+L98huMWhoDfzdgezmym9tgI8FOFnlREF1TwqX1a8vJk T+D+tcErAfkjVbTfnDepp7sifoAu3UEZF/zT/0I/dRmoOSSR2rjwdRjb4kz9onQugHbE woiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rsl6Z9az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a42si3579700edf.129.2020.11.17.05.39.17; Tue, 17 Nov 2020 05:39:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rsl6Z9az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733021AbgKQNh6 (ORCPT + 99 others); Tue, 17 Nov 2020 08:37:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:49160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732995AbgKQNh4 (ORCPT ); Tue, 17 Nov 2020 08:37:56 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 957B4207BC; Tue, 17 Nov 2020 13:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605620275; bh=iaaVi/kG/GEXKUfnpdvNXmq4FIzllGf18xVtxHBoDFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rsl6Z9az2DE6pAfNRET3LBihF0UU6OWkdQ8ngYOB0F2v7fOXBe/+/pFnjhEDYOL+h dBEfbnJ3fajsQgLXl2LlDVZ7dnaWw+dKloWeySK4G+X3NvdzBcMzzoZZSb+bJhlZKs QEcDiwywYdB2WLd9oW6VTYQ8AXjen+8GegxEuLK8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rohit Maheshwari , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.9 165/255] ch_ktls: Update cheksum information Date: Tue, 17 Nov 2020 14:05:05 +0100 Message-Id: <20201117122146.967639603@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117122138.925150709@linuxfoundation.org> References: <20201117122138.925150709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rohit Maheshwari [ Upstream commit 86716b51d14fc2201938939b323ba3ad99186910 ] Checksum update was missing in the WR. Fixes: 429765a149f1 ("chcr: handle partial end part of a record") Signed-off-by: Rohit Maheshwari Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/crypto/chelsio/chcr_ktls.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/chelsio/chcr_ktls.c index c5cce024886ac..026689d091102 100644 --- a/drivers/crypto/chelsio/chcr_ktls.c +++ b/drivers/crypto/chelsio/chcr_ktls.c @@ -926,6 +926,7 @@ chcr_ktls_write_tcp_options(struct chcr_ktls_info *tx_info, struct sk_buff *skb, struct iphdr *ip; int credits; u8 buf[150]; + u64 cntrl1; void *pos; iplen = skb_network_header_len(skb); @@ -964,22 +965,28 @@ chcr_ktls_write_tcp_options(struct chcr_ktls_info *tx_info, struct sk_buff *skb, TXPKT_PF_V(tx_info->adap->pf)); cpl->pack = 0; cpl->len = htons(pktlen); - /* checksum offload */ - cpl->ctrl1 = 0; - - pos = cpl + 1; memcpy(buf, skb->data, pktlen); if (tx_info->ip_family == AF_INET) { /* we need to correct ip header len */ ip = (struct iphdr *)(buf + maclen); ip->tot_len = htons(pktlen - maclen); + cntrl1 = TXPKT_CSUM_TYPE_V(TX_CSUM_TCPIP); #if IS_ENABLED(CONFIG_IPV6) } else { ip6 = (struct ipv6hdr *)(buf + maclen); ip6->payload_len = htons(pktlen - maclen - iplen); + cntrl1 = TXPKT_CSUM_TYPE_V(TX_CSUM_TCPIP6); #endif } + + cntrl1 |= T6_TXPKT_ETHHDR_LEN_V(maclen - ETH_HLEN) | + TXPKT_IPHDR_LEN_V(iplen); + /* checksum offload */ + cpl->ctrl1 = cpu_to_be64(cntrl1); + + pos = cpl + 1; + /* now take care of the tcp header, if fin is not set then clear push * bit as well, and if fin is set, it will be sent at the last so we * need to update the tcp sequence number as per the last packet. -- 2.27.0