Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3863375pxb; Tue, 17 Nov 2020 05:40:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrWSbFAnM503+Jr4SGljI4StjDhatpBXYeqZIAFXrjmqzIo1FclBVq2F4msM76StEc0h4M X-Received: by 2002:a50:bc04:: with SMTP id j4mr20206729edh.316.1605620452907; Tue, 17 Nov 2020 05:40:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605620452; cv=none; d=google.com; s=arc-20160816; b=hIPWMGd95AwdSb/BMD3/mKkvdNjgMjbvI0XsBhv1gV9g/ucxVHblMt6qQ2yMY7zmAE lgcYeEHW+tmc/14porf6QWibEAGZw/Ebbs42c+pC9uUcDUeRLj2PKnpirAxK+20UvHQL 4a+YwnwHd2oLDqrSqGW81mixdx7SLTxqAUa6Huy4Z9Ip0Eoi+dfoEbCdO7zOG7rFeiKZ 1OgCnCiNDYzaLZJtqmooKS7ywgJ8gav8GDf+uj1eDZAjFvLUlY1q4S7AvLo2962x5mFb 6p9r0rEGHH9vWa4epvXtSP+slKkBsg07a1RqRcAeCtFarw/yso0wQpwpJhM2zLcCFPJy se/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PbJmdFuBSAZqUwzzvMA4R4S/5bhuERDR4LHDfo2Fp24=; b=ndMqJcjxMMdYvE23kIN8zRxpPxiIvsIv2T8ws1Qhvnzf9gmSC15pA3qu1K/Ia1NhlA ptGPpzsq6dFtAlGRwfGMCyrGoBxOKRww5+lolnBw5bSOqLyLVE2bHTB+3VuA+4d5l8ZK TJraWKnkEJ3VMaMAkzwOWoX9L/SulAANcuIrMz2fGeyQ4GPFe2g/xtnoj3GFyBIA46Ci Kqnibh8WnJV8KdQUSey9csELqQaiE+6zKq1UJIROY4lqTrQtW164O0+wuxchvP1z/V69 VR+QU2SDWDIgq8R1Kqg3FDGrfDChZ3mL2yPSgfRQ5hd1oGdJTv8s7IL2x16Y5fd7eeX4 3FMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Glsm0ZoW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mc11si13573938ejb.154.2020.11.17.05.40.28; Tue, 17 Nov 2020 05:40:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Glsm0ZoW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732432AbgKQNhL (ORCPT + 99 others); Tue, 17 Nov 2020 08:37:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:47736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732634AbgKQNgm (ORCPT ); Tue, 17 Nov 2020 08:36:42 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59DE920780; Tue, 17 Nov 2020 13:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605620201; bh=r0Is9J5fXUHHtL1HAs2Y/S4Sh8gvigjEuYeP4gwcvao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Glsm0ZoWAOabNQgzCWPh/YxbFqw/erZqEX8bxjUCiHWOWi6ykA3X6Yx9lbx4Y/ArJ pPiLPyholcyL1EqTH5YgwrxyLXO4cQzwGnLpSoi9/U/AD0IIQRc8fGTnq7y4MxRLPs EJ9fBsOjGu6tSzUzCHzivOqnlWP9DpCTHjJk90ns= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Parav Pandit , Roi Dayan , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.9 140/255] net/mlx5: E-switch, Avoid extack error log for disabled vport Date: Tue, 17 Nov 2020 14:04:40 +0100 Message-Id: <20201117122145.760139481@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117122138.925150709@linuxfoundation.org> References: <20201117122138.925150709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Parav Pandit [ Upstream commit ae35859445607f7f18dd4f332749219cd636ed59 ] When E-switch vport is disabled, querying its hardware address is unsupported. Avoid setting extack error log message in such case. Fixes: f099fde16db3 ("net/mlx5: E-switch, Support querying port function mac address") Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index 6e6a9a5639928..e8e6294c7ccae 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -1902,8 +1902,6 @@ int mlx5_devlink_port_function_hw_addr_get(struct devlink *devlink, ether_addr_copy(hw_addr, vport->info.mac); *hw_addr_len = ETH_ALEN; err = 0; - } else { - NL_SET_ERR_MSG_MOD(extack, "Eswitch vport is disabled"); } mutex_unlock(&esw->state_lock); return err; -- 2.27.0