Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Nov 2020 16:54:01 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
        bgolaszewski@baylibre.com, andrew@aj.id.au, albeu@free.fr,
        f.fainelli@gmail.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com,
        Eugeniy.Paltsev@synopsys.com, hoan@os.amperecomputing.com,
        fancer.lancer@gmail.com, orsonzhai@gmail.com,
        baolin.wang7@gmail.com, zhang.lyra@gmail.com, vz@mleia.com,
        marek.behun@nic.cz, matthias.bgg@gmail.com,
        u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, grygorii.strashko@ti.com,
        ssantosh@kernel.org, khilman@kernel.org,
        manivannan.sadhasivam@linaro.org, p.zabel@pengutronix.de,
        linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros
Message-ID: <20201117155401.GC2589875@ulmo>
References: <20201117154340.18216-1-info@metux.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="f+W+jCU1fRNres8c"
Content-Disposition: inline
In-Reply-To: <20201117154340.18216-1-info@metux.net>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--f+W+jCU1fRNres8c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 17, 2020 at 04:43:40PM +0100, Enrico Weigelt, metux IT consult =
wrote:
> The of_match_ptr(foo) macro evaluates to foo, only if
> CONFIG_OF is set, otherwise to NULL. Same does ACPI_PTR with
> CONFIG_ACPI. That's very helpful for drivers that can be used
> with or without oftree / acpi.
>=20
> Even though most of the drivers touched here probably don't
> actually need that, it's also nice for consistency to make it
> the de-facto standard and change all drivers to use the
> of_match_ptr() and ACPI_PTR() macros.
>=20
> A nice side effect: in some situations, when compiled w/o
> CONFIG_OF/CONFIG_ACPI, the corresponding match tables could
> automatically become unreferenced and optimized-away by the
> compiler, w/o explicitly cluttering the code w/ ifdef's.

Isn't this going to cause a lot of "defined but unused" warnings when
built without OF support, for example?

Thierry

--f+W+jCU1fRNres8c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+z8hcACgkQ3SOs138+
s6FfaA//aqVfUF1MPmGuiib2ySGJqA3j6uXaK6UyaP9sIBxy0HGwTDDvPa1988JE
Rf8k6pipA56hbeeoO6cgi0TSlI47g/uZRjMMRO4QeRyfMDaShigw+5CQ70P1kBku
y44LrSK9CVLI1gZ775/HtNVlDB7qC+Qo48aHEKhSU2L2gE0LouJrIwSC9Fz6aOrI
d9b181DyykfbdRy8rijZzt1Y8Lc6/1HMI/Htfy9J4RvxCFWplHxnoKFHm+JeB8o5
YAl7MB1zNn43tOJwQJMhXUerfJ+aEAs3R+GyubzomQRLr1T+UDx+ITE1gzBXP76m
ZA50cuGvzFlY8wSK23a/YkOvgLqyxSY+b9AU34rkfH9t+pxurfzLh4lodtR7wbQ3
CsacvDumSFQ/IxNS5EmyHPMQoHxCMMZ3RL4FTgQegD1a72otSZTiW7luv7mV3A7a
cydkIiGtaW9rZD2xpmcQUlFziTdFKHDv+QzXBXJVFqNjtaZ650TkqItloLqEi1PU
phboKfrlfIeeIl09+UMlgLNmMg21xFMycylUdUepIIxcLZhEQQ408FD2WOUFvZ9x
6qoidPLoE+AmnVK2Cqg+W7hLZaY8toHO0j5C7IdyglWRQuvU6GtgGNz0BoGtqRyL
ArHVHA9cI1nQA7NJ1xtaFnKAI/xu3TN+JoEHoEgqCRzmnwv6g5Y=
=WjVu
-----END PGP SIGNATURE-----

--f+W+jCU1fRNres8c--