Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3966314pxb; Tue, 17 Nov 2020 08:04:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYO78bnK9TfJMzbB4eI272lsfb35l0wdbfhLpQjujmp+slHzmRU1bsUwccDm25SynakvIi X-Received: by 2002:a17:906:5fd6:: with SMTP id k22mr1604383ejv.333.1605629052237; Tue, 17 Nov 2020 08:04:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605629052; cv=none; d=google.com; s=arc-20160816; b=wdP3Eat7h6rXUApulqCLV9XeEw6tPfmSrEOX7+pd95E+vGBfDvGxj9V8v69zxPrixE klU5nnpOAp4VvSSJFscAJe/eGBtfBX5iGV1bARU4OJXXAHHGnL9BxgAuuL5ROXLGVAPX MMK/Bs/dqqdb8vYPKCSEM2vZGczUHDg5fkMsl4S9tWJPQIgAqhyTaq20wmGcStnoFlfr YJihfmdH4RKl/Cnt7D0urFLGu7OhaVGUo7sEh6kMbJh/cIhGMbPg1qi08B7f2C3QPLKM nqlQuikiG+T2J8Q3MszqxT0u0F11AwQhVs848/qCd3uRKpQC8LAgsmBjf1jPx+flEKUK sqYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZgH/N6mYWhDCoyFl6noMveCuC9qdA1oQrCHI6Be4/O0=; b=Z+nwuuMhzfhJ2UHL7K16f+vy2cSY9HUwTziU6PjB/MYXrq3XvWL2eLTkuGWCKLGKPb pZl3BrihkTfoPtZOz9MuLEhYqTDP6hrbCyj6HIIp+1E3LHhtGLVjCS4jKvacHNisi/L9 DFabFF1eg3c4psNsZeeedO/UnDXWDoTWU/lmREypNTv8ZFr8bHSnZ2fp0ZOavLLYB1zs ZMO4r4pdJq3bejTUDEPBVWa28SQC/XNWTtqKapE5uqnJUihiv4JhviUfnfJoafzN53f8 djq18v0xKRHle/8ogWzPRK1fmmkVMLQvptdmnAizA8Lo+PhOlvasqlYpRkexj1bP2Yxo 1Buw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jjlttYG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si14665379edx.188.2020.11.17.08.03.47; Tue, 17 Nov 2020 08:04:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jjlttYG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbgKQQBS (ORCPT + 99 others); Tue, 17 Nov 2020 11:01:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726544AbgKQQBR (ORCPT ); Tue, 17 Nov 2020 11:01:17 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A2A7C0617A6 for ; Tue, 17 Nov 2020 08:01:17 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h2so3765337wmm.0 for ; Tue, 17 Nov 2020 08:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZgH/N6mYWhDCoyFl6noMveCuC9qdA1oQrCHI6Be4/O0=; b=jjlttYG6IQC31dMZ14jB1N1t+o/y64mwNqlUUgR395EpocMaqgaplT3X2k4IAQ7LEz YJxAi0oK8N1vTgGGVkqSSyM/sas/I0DMTpVsM1AUZn9dxqRiFgToPuIdyPGUMc4u13ns Hf9ggBIL2Y1odExKxByo1Dc2vaEKKI/7oui6AEwnVIe/F1MUgVQCddJBXvp8aw6x/L82 kNLZ/SYen7+mbwd/cv5b7ydYnHzGKoTAAmN4upFES5n8UhxoOx1Y4g9Iicp/9IU+IgaQ Mf6fsYiHA+WPwVe2fAC2SJD0pTjr/OO3pTDMGbC6JduTqgKv3qbkO0OzqYg3Uj3GPnMJ uOvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZgH/N6mYWhDCoyFl6noMveCuC9qdA1oQrCHI6Be4/O0=; b=R19PifrtoGSnIxAoDBf6pbnJ/FnFmHfddlFyrzbizXU748fuwY4AYZaq6KkJbEkFIA quBBGooPpWb0sDsjk2lOs/XGdD3gJqatEuNI3TlEWMY9fokkAdP5LbptGUA9IAa2MlYe pc9lEDrjwuPx04qbHbqBe+ymCp31vA0tDIgj0bqyqusdDAc7tbewsPXM5/9fS7G6dfVK /7jn71kJkzpedh+InKxj88QD7ajfLg1uYn0fzFy/ynxRofjaiCGDhQaauZDStYp8u65O cBpAqrgCRfoDJbeG8NArPHFoyon1y4kB5tFYDLCRBAY5iahaTxm7dz8OtL6YPqK3Dgs+ PxhA== X-Gm-Message-State: AOAM530wkTsASeU2lliizm9z1eHLRTllhNfQ9fEv0vmwPA4NyCeZWj8n 2Eu5bSH43R4Mlf+MVme9gYt6kQ== X-Received: by 2002:a1c:208f:: with SMTP id g137mr342521wmg.116.1605628875733; Tue, 17 Nov 2020 08:01:15 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id d8sm4077249wmb.11.2020.11.17.08.01.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 08:01:15 -0800 (PST) Date: Tue, 17 Nov 2020 16:01:12 +0000 From: Lee Jones To: Thierry Reding Cc: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, andrew@aj.id.au, albeu@free.fr, f.fainelli@gmail.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, Eugeniy.Paltsev@synopsys.com, hoan@os.amperecomputing.com, fancer.lancer@gmail.com, orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, vz@mleia.com, marek.behun@nic.cz, matthias.bgg@gmail.com, u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, manivannan.sadhasivam@linaro.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros Message-ID: <20201117160112.GI1869941@dell> References: <20201117154340.18216-1-info@metux.net> <20201117155401.GC2589875@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201117155401.GC2589875@ulmo> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020, Thierry Reding wrote: > On Tue, Nov 17, 2020 at 04:43:40PM +0100, Enrico Weigelt, metux IT consult wrote: > > The of_match_ptr(foo) macro evaluates to foo, only if > > CONFIG_OF is set, otherwise to NULL. Same does ACPI_PTR with > > CONFIG_ACPI. That's very helpful for drivers that can be used > > with or without oftree / acpi. > > > > Even though most of the drivers touched here probably don't > > actually need that, it's also nice for consistency to make it > > the de-facto standard and change all drivers to use the > > of_match_ptr() and ACPI_PTR() macros. > > > > A nice side effect: in some situations, when compiled w/o > > CONFIG_OF/CONFIG_ACPI, the corresponding match tables could > > automatically become unreferenced and optimized-away by the > > compiler, w/o explicitly cluttering the code w/ ifdef's. > > Isn't this going to cause a lot of "defined but unused" warnings when > built without OF support, for example? Yes, it will. It also looks like there are some whitespace changes in the patch, unless of course that's just Git playing tricks! -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog