Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3974436pxb; Tue, 17 Nov 2020 08:14:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJznIOKeOwsoaC6+WwPWHYyyoDw6zQT0UKhF/WQ4S6EcehkgtkmPuNW1LgOb7xrDVhlpd8nb X-Received: by 2002:a17:906:4ed2:: with SMTP id i18mr20531129ejv.195.1605629649644; Tue, 17 Nov 2020 08:14:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605629649; cv=none; d=google.com; s=arc-20160816; b=ZQRse0aZ6iPhYm5iNMw1dGXExNF0C4k7FvDP2rdQuaZV8wYtEalepp+2OxCi77U1XO t4+kbEknXFQw+JVgNbEOQlEZK/Kvl8edT5Au3ldVJgFyNZqo4AI4ISFYQ37CdwfvSA7d HlgkME1jrIobXSmzsEIKzaqc7E5h9zl1KkxH4Nmb/D1qi0TLpVhuWDsJ9emwy5S5+/j8 seOX9RzGyOK+kPtq2S/hMsJ5P5Aacmz25qVQsj1u5d/FKvVljlWwZFJrT1OkIdVn31W+ 9iQcosQlxh39JTYEw6PWdc/fuygqMFyUoqZxqKkN23wCAsk/geFbtQY3HuHY+R4QlOzQ S/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fH5YUnHmjgjmGMD+NeJ2A/YFragDQMyXp+pq8qmaCXQ=; b=nByUiNzShVjwYH5aw3ZVvzmrSpH1AqI+czuYytcrw15QC3AsDbVyD0OmHUONR4/KDw GtBO3tMyVKvAwUv9/xhJuvFTVZgOrFnV2sxvReE2ZBc5ySglTer6Uk+OxTcUR8dH7Hz4 37qeI3bly2BW64sGNJqU1UOaR7QCZy8QZdAatX5o4l8hbxZAfwIoyd2dWvsg1TG54qAe aTqlyQQWPNBNqPyKpQimoluYXywm1yoW5u96M8uaU+wQ500J/5Zz+NCRdx4hxZ9St1XH g10TfiA/rjSPpZsIt9SM0KwhqoFbh52OqglcaSRgussqigJ7EEVBRXaBjV+MnHYxsYQF VAoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qq184SXt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si13829805ejg.0.2020.11.17.08.13.46; Tue, 17 Nov 2020 08:14:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qq184SXt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727199AbgKQQLe (ORCPT + 99 others); Tue, 17 Nov 2020 11:11:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:42638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgKQQLd (ORCPT ); Tue, 17 Nov 2020 11:11:33 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45C2C22240; Tue, 17 Nov 2020 16:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605629493; bh=+0+uKSU55cw8NMsseuTud1DNBTgmYmdc0AkLJ6osu6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qq184SXtTxa/zKKpBRujx5yppGEM0x1TljCq59XyFpEG5E6wRU1BWERrZj2pmsj7C yEw/b1vgS2B45dIIlPbPPzsuWr5XRprJusZPpoC7gHm95914tb6fcFI+HwB+ZWDI2/ J9W/44zs0ObWinfpB4KFsYBdmfeM9NX2i524lGfg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Liu, Yi L" , Yi Sun , Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 5.9 041/255] iommu/vt-d: Fix a bug for PDP check in prq_event_thread Date: Tue, 17 Nov 2020 14:03:01 +0100 Message-Id: <20201117122140.948344102@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117122138.925150709@linuxfoundation.org> References: <20201117122138.925150709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liu, Yi L [ Upstream commit 71cd8e2d16703a9df5c86a9e19f4cba99316cc53 ] In prq_event_thread(), the QI_PGRP_PDP is wrongly set by 'req->pasid_present' which should be replaced to 'req->priv_data_present'. Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode") Signed-off-by: Liu, Yi L Signed-off-by: Yi Sun Acked-by: Lu Baolu Link: https://lore.kernel.org/r/1604025444-6954-3-git-send-email-yi.y.sun@linux.intel.com Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index a71fbbddaa66e..20fa8c7fcd8e7 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -1001,7 +1001,7 @@ no_pasid: resp.qw0 = QI_PGRP_PASID(req->pasid) | QI_PGRP_DID(req->rid) | QI_PGRP_PASID_P(req->pasid_present) | - QI_PGRP_PDP(req->pasid_present) | + QI_PGRP_PDP(req->priv_data_present) | QI_PGRP_RESP_CODE(result) | QI_PGRP_RESP_TYPE; resp.qw1 = QI_PGRP_IDX(req->prg_index) | -- 2.27.0