Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3974648pxb; Tue, 17 Nov 2020 08:14:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFydoie/CPXhuCrxdw15Dyi9hRV26nGltOfDyoPTS/Ga1f86dHkhWA+DX+ic6BIK5foDfi X-Received: by 2002:a50:fe14:: with SMTP id f20mr20492843edt.61.1605629665138; Tue, 17 Nov 2020 08:14:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605629665; cv=none; d=google.com; s=arc-20160816; b=kRk8CaPpnM42aLifXdWgp15PpNRQ/PDHjqch+6d5O1U4UV9hN6yXLSn4oeqkanZBSc RFxXJF4GaLzTw5JyH+1CiIPgyZ/2jq04uBdRRn7opjLkH3c5I9QOtv8btawoAjnRgnSB YubLDZ758jBfPdD3COJPduHC3ncA46ujPATopkb92WiehRmluTaOkb966gB5SFqtJMUB SO7ytY5oiJYHe/CZxDD0SSjqSlTIHeFE0HcO6YQKr9m8xHBider7SgCKMhG5WVK3XvTb TVUy2YbzULPWlFsvRmvjU+zeaTxZXXJtbMWt51aT8BOasXYQpPxwv52BjAApm7/7bh/X 7DgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=srxsVUqO8X9VgqPv99i3d1Np6gGsQ+QWasl8UyY3Qcw=; b=0yb9TtZTDlTxrp1mGT7RZXShXFnxpS5ljY4eJ2skq2gi2EhPMobckn2TLwqb+hao1T gh6Os/mBnRzDSt5YQ+XLwtv+eJMNBvmDdY4Q+zZvsMWZoDOcHjIclgKtLlycy5A/xtrP x99kAU+NK9YXGovJS0NwuQ+fUcwz3+/BVPXty34ZhkxNYBaPTkPEDbEHwPvmBtpMaz/N 9g2CaJZvxkGVjReE7JzVANk75ocbWcdBDu+IIjpvjtiKFQzddiZlL79b+0hhI96GgcS/ A3ssJmhXJ0IRcV2XjzFo57JBvL7/YefLw4JxcqvVnOo7qwQdGtBDuhbFKt21P93iCQKD p6DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JPB6honU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si13587471ejv.71.2020.11.17.08.14.01; Tue, 17 Nov 2020 08:14:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JPB6honU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbgKQQKa (ORCPT + 99 others); Tue, 17 Nov 2020 11:10:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:41962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgKQQKa (ORCPT ); Tue, 17 Nov 2020 11:10:30 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F85B2467D; Tue, 17 Nov 2020 16:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605629429; bh=WYWEjT4lDX5/lkP5vF2QMGtyN9rB/hXvYbR9C0SxpuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JPB6honUAgBQ+q6K0H7SJCnuRWp71EvL7rLvIT555GHmh3C8qi15yIbL9wdc1m9+W hkaoBLOi/Vf70ranhekz/YjobYh14f8JgPix/S8B2tqpeRk5NwwJ8ZKWIjEN9jPJSr B6f2vWmhemgDxrMDn5524fS2KGKA6yA73qi28V6Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Liu, Yi L" , Yi Sun , Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 5.4 024/151] iommu/vt-d: Fix a bug for PDP check in prq_event_thread Date: Tue, 17 Nov 2020 14:04:14 +0100 Message-Id: <20201117122122.585934640@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117122121.381905960@linuxfoundation.org> References: <20201117122121.381905960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liu, Yi L [ Upstream commit 71cd8e2d16703a9df5c86a9e19f4cba99316cc53 ] In prq_event_thread(), the QI_PGRP_PDP is wrongly set by 'req->pasid_present' which should be replaced to 'req->priv_data_present'. Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode") Signed-off-by: Liu, Yi L Signed-off-by: Yi Sun Acked-by: Lu Baolu Link: https://lore.kernel.org/r/1604025444-6954-3-git-send-email-yi.y.sun@linux.intel.com Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel-svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index 1d3816cd65d57..ec69a99b99bab 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -646,7 +646,7 @@ static irqreturn_t prq_event_thread(int irq, void *d) resp.qw0 = QI_PGRP_PASID(req->pasid) | QI_PGRP_DID(req->rid) | QI_PGRP_PASID_P(req->pasid_present) | - QI_PGRP_PDP(req->pasid_present) | + QI_PGRP_PDP(req->priv_data_present) | QI_PGRP_RESP_CODE(result) | QI_PGRP_RESP_TYPE; resp.qw1 = QI_PGRP_IDX(req->prg_index) | -- 2.27.0