Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4012517pxb; Tue, 17 Nov 2020 09:05:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6n+Hus/nOo0fK2a2b9F1d42ggNnvBsWBu4uT15J3jLr6Zj4pizlCESDI9oHLpkK7DSS5q X-Received: by 2002:a17:906:80ca:: with SMTP id a10mr21111086ejx.351.1605632738788; Tue, 17 Nov 2020 09:05:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605632738; cv=none; d=google.com; s=arc-20160816; b=BCcpWeLi00x62tsqjmkALWLbg4uwS57GC5hpn/kptpPdc3bskRhcUhNgQDTPvXvhNZ pcEnd3+Edr+tiBRGgBnCmoWuFMfYI+kY4ghPRsLp+dWSohXhTKqb+DfKGWCT+7fvx94d IjjhjjCepv/4Ek4Go5DgAkPHuTcuLQq3VI8nJx1VkK0hwv3xHmm1d6bDwTgNMgFLmqTf D37SnNKa+1wCD1V+utV0Dfaf4vrjjLmuSgx2lGi1sLSQ7NPOZu+cpcjEa5afO0AwYeIT 4Af9B9ddlMidrYnPsYohj8T4wEgUGInXGwVUBzPXLt7ffc95caceDuMG+PSD6rlUxRCs KKMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E8hP8PKV6fbycNU+r0xtorLaBw0aFfvnNyJ5aZZqz68=; b=AbrlqMECLOmToO7bRERT++4QFpEUwATDe/v1cYrzoTkyLFwWgsKCODjHohT5tDf75i Up0pdLdh9KJ9vOQfTgsQQIcEKwF+guLo6R670DmLYqupQLR0wPuK6BbigHK7BNigTWMd 89CcSb1Bf4kE6dcNZyYv6OHIX8asAKAGlS8lvqbJy/cTPp8mbcHzvo0zlbN3porpQIXV svfsXZkD/X8aTjjSeHlG5jUi4zf1FDr0WcXeCWcACpwkd0uLc4HGAWOfECVZxkJrWjCt XjVw74OYorJypJonKBwPUhE5voJU6t7QSzJk5i1Gqktwsl+UrFGLpS1HAgcqrsPecSsT 4RBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CR+JWaFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cb21si13660553edb.267.2020.11.17.09.05.11; Tue, 17 Nov 2020 09:05:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CR+JWaFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728256AbgKQQ6q (ORCPT + 99 others); Tue, 17 Nov 2020 11:58:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:43760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728160AbgKQQ6q (ORCPT ); Tue, 17 Nov 2020 11:58:46 -0500 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B27ED22447; Tue, 17 Nov 2020 16:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605632325; bh=m7fEyJUI86RiTgxV9+ZcE0tSXdxgH+KJnjANyYtn9M4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CR+JWaFfhsK7T7TE0ZrhviYZZ4wXj3vwiye5RhMiAI/xay3TpbbVauBLUPvldOq5y xUHConB81QOSBhCpyAS2OZ2WRliWc9q5odd7H/fC/4hFIrXTaCdrUgdIaPknUaT2UC VapYYJb+X/1MTBrpVlgA1t/7Nv/cQxjHUqoaEc5o= From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-team@android.com Cc: cang@codeaurora.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, martin.petersen@oracle.com, stanley.chu@mediatek.com, Jaegeuk Kim Subject: [PATCH v5 1/7] scsi: ufs: avoid to call REQ_CLKS_OFF to CLKS_OFF Date: Tue, 17 Nov 2020 08:58:33 -0800 Message-Id: <20201117165839.1643377-2-jaegeuk@kernel.org> X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog In-Reply-To: <20201117165839.1643377-1-jaegeuk@kernel.org> References: <20201117165839.1643377-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Once UFS was gated with CLKS_OFF, it should not call REQ_CLKS_OFF again, which caused hibern8_enter failure. Signed-off-by: Jaegeuk Kim --- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b8f573a02713..cc8d5f0c3fdc 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1745,7 +1745,8 @@ static void __ufshcd_release(struct ufs_hba *hba) if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended || hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL || ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks || - hba->active_uic_cmd || hba->uic_async_done) + hba->active_uic_cmd || hba->uic_async_done || + hba->clk_gating.state == CLKS_OFF) return; hba->clk_gating.state = REQ_CLKS_OFF; -- 2.29.2.299.gdc1121823c-goog