Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201110195753.530157-1-guro@fb.com>
In-Reply-To: <20201110195753.530157-1-guro@fb.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Tue, 17 Nov 2020 09:16:48 -0800
Message-ID: <CALvZod5pd=Y_DC8mTs6Uc2+McPe7iEQs5hHtGbOFCA9EAVDe9w@mail.gmail.com>
Subject: Re: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization
To:     Roman Gushchin <guro@fb.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <kernel-team@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 10, 2020 at 11:58 AM Roman Gushchin <guro@fb.com> wrote:
>
> It's convenient to have page->objects initialized before calling
> into account_slab_page(). In particular, this information can be
> used to pre-alloc the obj_cgroup vector.
>
> Let's call account_slab_page() a bit later, after the initialization
> of page->objects.
>
> This commit doesn't bring any functional change, but is required for
> further optimizations.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>

Reviewed-by: Shakeel Butt <shakeelb@google.com>