Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4079416pxb; Tue, 17 Nov 2020 10:41:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeeDKpv6EVqTKkZ5GMa0Wvjao3koa+niup0JZGKKV66WsGPogUPbRZ9B9W+vX1nRMWW4pU X-Received: by 2002:a17:906:9719:: with SMTP id k25mr19981367ejx.226.1605638460927; Tue, 17 Nov 2020 10:41:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605638460; cv=none; d=google.com; s=arc-20160816; b=ovSArPoJys9edPn1/nI05YSGtmz1vYAd0c7fE0FSu7zpvkbb/LskmjmJ/Hnv35bFi0 z37j0teZ7D54wXaXnpTFOC8zJp+mxLmnKiqZjcYvkpcJXGyiGAeAtwbZpfD9kJQv5WDJ bhqIdC3AQcEcFBeKutFp/TfSCBiGY1xJL3Z7zOd53l3hWP/J73SANVkiLPwP0Yqz68RB jSf0vR8y4Etug1kHGL97gAf4Qh2fdORZtq2/uvFZ5T80bhKGBpobEBNnSFScX3DRiYC1 yPXdwYMzjNcPz+VFiqIAAcye/kVf7tldkbzf8KpZEoPeYnJpDvA4psyM983RGpGIj4yd 2jVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=2Un7bkg9kXjFs/tVAi75i1Yourocf7dyVv1ILRh6JPc=; b=fzqSWY0Hd8DiWD5SzTQf9WHN1cniBh23jak57gfVW98rp1zkm2En73QtoSNsbM4JBq aQRrIdec0NPn05umkNnmj20dcciM0rNY8M1ANPzT3d0YcVw1n2FqkSIPPgvvpqL6s428 7U8GPM8tPEAwB/R1Gy2KGCRuVpuZSdmzjLLUYZE+p5ftCVahFHrPu8XdviTFpk1IXSFQ gGC7+tH+Rv4ZK7Fd3SIcjl3ko0VmSCqnijLNwWZRup0/lce/s/sudoW7yfH8m9tYCjrY mXvuLQv/UJIu1IcUhNOrPrcK+VB8QcbiMFc13//IxpWyRywpgazTU4cGYofVOKZnp3Oj hZKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D1amKCll; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hh23si13888663ejb.752.2020.11.17.10.40.37; Tue, 17 Nov 2020 10:41:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D1amKCll; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731439AbgKQSgu (ORCPT + 99 others); Tue, 17 Nov 2020 13:36:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729502AbgKQSgt (ORCPT ); Tue, 17 Nov 2020 13:36:49 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592DCC0613CF; Tue, 17 Nov 2020 10:36:49 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id 62so16594415pgg.12; Tue, 17 Nov 2020 10:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2Un7bkg9kXjFs/tVAi75i1Yourocf7dyVv1ILRh6JPc=; b=D1amKCllKBkpeP1HKint4pL8bRnIH8WYMUMAYX1vO49nYeZjFa8FiBzSBfdsr6CKpC gVGLhJJ5ks5qUPh0OWlGcmhn5/IzJ7HnePG3i0DrYEc7rFYnU5gUtDNqbpiRya3xiW8f rdSlY98HNxUMAQ6HbXuqKaci6Ap+lstjKnPZ2cUceP/rwHUNSBS6z9pMxiLv0HWf0E3T 8DYpTpC0cfziBcmxzsPUX54UtVqQU3VjyvzL+EDX1+67oUv9Q50K+jOhvowId7/NAcbn Zg7+3XkaEt/yMclBSSHYZpbrfou7p8rvTGnsbtYC/yLnSxUeVIpAiCuhYTcSSnDVOJUx P63Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2Un7bkg9kXjFs/tVAi75i1Yourocf7dyVv1ILRh6JPc=; b=i/e8h7kfeHfT3QINT48pl8wachHtfpivRjEtpexyKTHPVjDVdYwUIWFzJLAQuukGfF 9NGCWoNpFzIJKs5tYy/WCtOkrXYYdCa9I7ucw7LK0J0GkCjrXOU6AS3O180KONESosSi F1WKca4qY3QT19DN0BXbcqPeLBCcuILIHUCY8K3g2LNkEhEOv5u2wR9kg1xzi6e5roSC 1621EphL0ele99zgwh6hesmq4vt0IXiJFw0qePNsUkPYzsuRtNJeOUN4xPbKnlg0+AHV Q1Rd5vYhufsZ45PUFFQRJzHFj1DpmQEtGX88Z7vvBWKhwOh4PjPViDs6YmPU49cLD4W4 a4tw== X-Gm-Message-State: AOAM530hwZOmAOCd3LVLcABlXr2z0oQjwlp9CYKptfCTNcZ6Yj0IigPL gqbrV4iBDGlRYiPkWnPMLfQ= X-Received: by 2002:a65:5588:: with SMTP id j8mr4534952pgs.245.1605638208955; Tue, 17 Nov 2020 10:36:48 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q19sm22568824pfh.37.2020.11.17.10.36.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 10:36:48 -0800 (PST) Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function To: Martin Blumenstingl , davem@davemloft.net, kuba@kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org Cc: jianxin.pan@amlogic.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khilman@baylibre.com, narmstrong@baylibre.com, jbrunet@baylibre.com, andrew@lunn.ch References: <20201115185210.573739-1-martin.blumenstingl@googlemail.com> <20201115185210.573739-5-martin.blumenstingl@googlemail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 17 Nov 2020 10:36:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201115185210.573739-5-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/20 10:52 AM, Martin Blumenstingl wrote: > Newer SoCs starting with the Amlogic Meson G12A have more a precise > RGMII RX delay configuration register. This means more complexity in the > code. Extract the existing RGMII delay configuration code into a > separate function to make it easier to read/understand even when adding > more logic in the future. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian