Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Nov 2020 10:52:59 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Michael Chan <michael.chan@broadcom.com>
Cc:     Zhang Changzhong <zhangchangzhong@huawei.com>,
        David Miller <davem@davemloft.net>, Larry.Finger@lwfinger.net,
        akpm@linux-foundation.org, fujita.tomonori@lab.ntt.co.jp,
        "John W. Linville" <linville@tuxdriver.com>,
        Netdev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: b44: fix error return code in b44_init_one()
Message-ID: <20201117105259.09a6e011@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <CACKFLikSSW+dozWu9TWH1CVqxOCBjq4GiUQBbL5JSprg6H2qVA@mail.gmail.com>
References: <1605582131-36735-1-git-send-email-zhangchangzhong@huawei.com>
        <CACKFLikSSW+dozWu9TWH1CVqxOCBjq4GiUQBbL5JSprg6H2qVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 16 Nov 2020 20:13:43 -0800 Michael Chan wrote:
> On Mon, Nov 16, 2020 at 7:01 PM Zhang Changzhong wrote:
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 39a6f4bce6b4 ("b44: replace the ssb_dma API with the generic DMA API")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>  
> 
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Applied, thanks!