Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: abhinavk=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 17 Nov 2020 12:34:56 -0800
From:   abhinavk@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Rob Clark <robdclark@gmail.com>, freedreno@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>,
        kalyan_t@codeaurora.org
Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print
In-Reply-To: <20201117172608.2091648-1-swboyd@chromium.org>
References: <20201117172608.2091648-1-swboyd@chromium.org>
Message-ID: <71aebca216babf4010c92d4d1ce9a9b4@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2020-11-17 09:26, Stephen Boyd wrote:
> I don't know what this debug print is for but it is super chatty,
> throwing 8 lines of debug prints in the logs every time we update a
> plane. It looks like it has no value. Let's nuke it so we can get
> better logs.
> 
> Cc: Sean Paul <sean@poorly.run>
> Cc: Abhinav Kumar <abhinavk@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> index 5e8c3f3e6625..5eb2b2ee09f5 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
> @@ -245,9 +245,6 @@ void dpu_vbif_set_qos_remap(struct dpu_kms 
> *dpu_kms,
>  	forced_on = mdp->ops.setup_clk_force_ctrl(mdp, params->clk_ctrl, 
> true);
> 
>  	for (i = 0; i < qos_tbl->npriority_lvl; i++) {
> -		DPU_DEBUG("vbif:%d xin:%d lvl:%d/%d\n",
> -				params->vbif_idx, params->xin_id, i,
> -				qos_tbl->priority_lvl[i]);

Instead of getting rid of this print, we should optimize the caller of 
this. This is what
we are doing in downstream. So we need to update the property only if we 
are switching from a RT client
to non-RT client for the plane and vice-versa. So we should try to do 
the same thing here.

  	is_rt = sde_crtc_is_rt_client(crtc, crtc->state);
  	if (is_rt != psde->is_rt_pipe) {
  		psde->is_rt_pipe = is_rt;
  		pstate->dirty |= SDE_PLANE_DIRTY_QOS;
  	}


  	if (pstate->dirty & DPU_PLANE_DIRTY_QOS)
  		_dpu_plane_set_qos_remap(plane);