Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] print_req_error: Use dev_err_ratelimited
From:   Tony Asleson <tasleson@redhat.com>
To:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201026160515.542586-1-tasleson@redhat.com>
Organization: Red Hat
Message-ID: <24d6bc43-d50a-7845-6fcc-ed65b779242e@redhat.com>
Date:   Tue, 17 Nov 2020 14:41:29 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201026160515.542586-1-tasleson@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Any thoughts on this?

Getting all the error paths to go through dev_printk is
quite useful.


On 10/26/20 11:05 AM, Tony Asleson wrote:
> Replace printk_ratelimited with dev_err_ratelimited which
> adds dev_printk meta data. This is used by journald to
> add disk ID information to the journal entry.
> 
> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---
>  block/blk-core.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 10c08ac50697..ee5d63e54a11 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -216,16 +216,18 @@ EXPORT_SYMBOL_GPL(blk_status_to_errno);
>  static void print_req_error(struct request *req, blk_status_t status,
>  		const char *caller)
>  {
> +	struct device *dev;
>  	int idx = (__force int)status;
>  
>  	if (WARN_ON_ONCE(idx >= ARRAY_SIZE(blk_errors)))
>  		return;
>  
> -	printk_ratelimited(KERN_ERR
> -		"%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
> +	dev = req->rq_disk ? disk_to_dev(req->rq_disk) : NULL;
> +
> +	dev_err_ratelimited(dev,
> +		"%s: %s error, sector %llu op 0x%x:(%s) flags 0x%x "
>  		"phys_seg %u prio class %u\n",
>  		caller, blk_errors[idx].name,
> -		req->rq_disk ? req->rq_disk->disk_name : "?",
>  		blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
>  		req->cmd_flags & ~REQ_OP_MASK,
>  		req->nr_phys_segments,
> 
> base-commit: bbf5c979011a099af5dc76498918ed7df445635b
>