Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Tue, 17 Nov 2020 12:42:04 -0800
From:   Minchan Kim <minchan@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Vijayanand Jitta <vjitta@codeaurora.org>,
        linux-mm <linux-mm@kvack.org>, glider@google.com,
        Dan Williams <dan.j.williams@intel.com>, broonie@kernel.org,
        mhiramat@kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yogesh Lal <ylal@codeaurora.org>,
        Vinayak Menon <vinmenon@codeaurora.org>
Subject: Re: [PATCH] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Message-ID: <20201117204204.GA3905260@google.com>
References: <1603372546-27118-1-git-send-email-vjitta@codeaurora.org>
 <CAEwNFnBvxu7+oNkcO9D70OFrxQXswcJG4OvDPyzNf7kpXfpSuw@mail.gmail.com>
 <282d7028-498d-50b3-37d4-2381571f9f9e@codeaurora.org>
 <ed4a1e75-3e3a-4950-7bb5-3d83db7bf054@codeaurora.org>
 <20201112145649.3fcd9dc4d6d3db4bd26245bb@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112145649.3fcd9dc4d6d3db4bd26245bb@linux-foundation.org>
Precedence: bulk

On Thu, Nov 12, 2020 at 02:56:49PM -0800, Andrew Morton wrote:
> On Thu, 12 Nov 2020 18:26:24 +0530 Vijayanand Jitta <vjitta@codeaurora.org> wrote:
> 
> > >> 1. page_owner=off, stackdepot_stack_hash=0 -> no more wasted memory
> > >> when we don't use page_owner
> > >> 2. page_owner=on, stackdepot_stack_hash=8M -> reasonable hash size
> > >> when we use page_owner.
> > >>
> > >>
> > > 
> > > This idea looks fine to me. Andrew and others would like to hear your
> > > comments as well on this before implementing.
> > > 
> > > Thanks,
> > > Vijay
> > > 
> > 
> > Awaiting for comments from Andrew and others.
> 
> I don't actually understand the problem.
> 
> What is it about page-owner that causes stackdepot to consume
> additional memory?  As far as I can tell, sizeof(struct stack_record)
> isn't affected by page-owner?
> 

Thing is once we build stackdepot due to the dependency from page_owner,
it will consume 8M regardless of using page_owner.

#define STACK_HASH_SIZE (1L << CONFIG_STACK_HASH_ORDER_SHIFT)

static struct stack_record *stack_table[STACK_HASH_SIZE] = {
	[0 ...  STACK_HASH_SIZE - 1] = NULL
};

So if we decide the size option at build time, we should consume
the memory anyway regardless of page_owner enabling in runtime.