Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Nov 2020 12:45:25 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Zhang Changzhong <zhangchangzhong@huawei.com>, jcliburn@gmail.com,
        chris.snook@gmail.com, davem@davemloft.net, hkallweit1@gmail.com,
        yanaijie@huawei.com, mst@redhat.com, leon@kernel.org,
        jesse.brandeburg@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] atl1c: fix error return code in atl1c_probe()
Message-ID: <20201117124525.5c4b28b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <83ee32e6-9460-a1f1-8065-6e737edb5402@wanadoo.fr>
References: <1605581721-36028-1-git-send-email-zhangchangzhong@huawei.com>
        <83ee32e6-9460-a1f1-8065-6e737edb5402@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 17 Nov 2020 21:39:05 +0100 Marion & Christophe JAILLET wrote:
> Le 17/11/2020 =C3=A0 03:55, Zhang Changzhong a =C3=A9crit=C2=A0:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") =
=20
> Hi, should it have any importance, the Fixes tag is wrong.
>=20
> The issue was already there before 85eb5bc33717 which was just a=20
> mechanical update.

Can you provide the correct one, then?

I can switch it when applying.