Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Nov 2020 21:50:37 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 23/24] perf buildid-list: Add support for mmap2's buildid
 events
Message-ID: <20201117205037.GI1216482@krava>
References: <20201117110053.1303113-1-jolsa@kernel.org>
 <20201117110053.1303113-24-jolsa@kernel.org>
 <20201117125040.GT614220@kernel.org>
 <20201117152140.GE1216482@krava>
 <20201117175400.GV614220@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201117175400.GV614220@kernel.org>
Precedence: bulk

On Tue, Nov 17, 2020 at 02:54:00PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 17, 2020 at 04:21:40PM +0100, Jiri Olsa escreveu:
> > On Tue, Nov 17, 2020 at 09:50:40AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Tue, Nov 17, 2020 at 12:00:52PM +0100, Jiri Olsa escreveu:
> > > > Add buildid-list support for mmap2's build id data, so we can
> > > > display build ids for dso objects for data without the build
> > > > id cache update.
> > > 
> > > >   $ perf buildid-list
> > > >   1805c738c8f3ec0f47b7ea09080c28f34d18a82b /usr/lib64/ld-2.31.so
> > > >   d278249792061c6b74d1693ca59513be1def13f2 /usr/lib64/libc-2.31.so
> > > > 
> > > > By default only dso objects with hits are shown.
> > > 
> > > Would be interesting to be able to show all the build ids that are
> > > there. a 'perf buildid-list --all' or make this under --force?
> > 
> > ok, will check.. one other tool I think would be handy is
> > to show which debuginfo is not available, because it can
> > change the report a lot - missing symbols are not getting
> > accounted, and their hits are accounted only as separated
> > addresses
> 
> Right, as below.
> 
> So you suggest something like:
> 
>   # perf buildid-cache --fetch-missing-debuginfo

haven't thought about interface yet, just noticed it's something
that's not so easy to find out while we can present it to user quite
easily

the interface needs to have perf.data in it, because buildid-cache
does not work on top of perf.data, perhaps something like:

   # perf report --show-missing-debuginfo

or on top of current interface:

   # perf buildid-cache -a perf.data --show-missing-debuginfo

jirka