Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965247AbWHWWTm (ORCPT ); Wed, 23 Aug 2006 18:19:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965246AbWHWWTm (ORCPT ); Wed, 23 Aug 2006 18:19:42 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:33511 "EHLO e31.co.us.ibm.com") by vger.kernel.org with ESMTP id S965247AbWHWWTl (ORCPT ); Wed, 23 Aug 2006 18:19:41 -0400 Subject: Re: [Devel] [PATCH 1/6] BC: kconfig From: Matt Helsley To: Dave Hansen Cc: devel@openvz.org, Andrew Morton , Rik van Riel , Chandra Seetharaman , Greg KH , Linux Kernel Mailing List , Andi Kleen , Christoph Hellwig , Andrey Savochkin , Alan Cox , Rohit Seth , Oleg Nesterov In-Reply-To: <1156370698.12011.55.camel@localhost.localdomain> References: <44EC31FB.2050002@sw.ru> <44EC35A3.7070308@sw.ru> <1156370698.12011.55.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 23 Aug 2006 15:13:42 -0700 Message-Id: <1156371222.2510.715.camel@stark> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 41 On Wed, 2006-08-23 at 15:04 -0700, Dave Hansen wrote: > On Wed, 2006-08-23 at 15:01 +0400, Kirill Korotaev wrote: > > --- ./arch/sparc64/Kconfig.arkcfg 2006-07-17 17:01:11.000000000 +0400 > > +++ ./arch/sparc64/Kconfig 2006-08-10 17:56:36.000000000 +0400 > > @@ -432,3 +432,5 @@ source "security/Kconfig" > > source "crypto/Kconfig" > > > > source "lib/Kconfig" > > + > > +source "kernel/bc/Kconfig" > ... > > --- ./arch/sparc64/Kconfig.arkcfg 2006-07-17 17:01:11.000000000 +0400 > > +++ ./arch/sparc64/Kconfig 2006-08-10 17:56:36.000000000 +0400 > > @@ -432,3 +432,5 @@ source "security/Kconfig" > > source "crypto/Kconfig" > > > > source "lib/Kconfig" > > + > > +source "kernel/bc/Kconfig" > > Is it just me, or do these patches look a little funky? Looks like it > is trying to patch the same thing into the same file, twice. Also, the > patches look to be -p0 instead of -p1. They do appear to be -p0 They aren't adding the same thing twice to the same file. This patch makes different arches source the same Kconfig. I seem to recall Chandra suggested that instead of doing it this way it would be more appropriate to add the source line to init/Kconfig because it's more central and arch-independent. I tend to agree. Cheers, -Matt Helsley - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/