Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1605592689-10108-1-git-send-email-yejune.deng@gmail.com>
In-Reply-To: <1605592689-10108-1-git-send-email-yejune.deng@gmail.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Tue, 17 Nov 2020 23:52:14 +0100
Message-ID: <CAFBinCCQTTAR9dTpf8pWb4D=+Hc2Tjxj1WE1KYqsyT-S-XPdtA@mail.gmail.com>
Subject: Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
To:     Yejune Deng <yejune.deng@gmail.com>
Cc:     kishon@ti.com, vkoul@kernel.org, khilman@baylibre.com,
        Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com,
        p.zabel@pengutronix.de, lorenzo.pieralisi@arm.com,
        repk@triplefau.lt, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Yejune,

On Tue, Nov 17, 2020 at 6:58 AM Yejune Deng <yejune.deng@gmail.com> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
>  drivers/phy/amlogic/phy-meson-axg-pcie.c       | 2 +-
>  drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
>  drivers/soc/amlogic/meson-ee-pwrc.c            | 3 +--
>  drivers/soc/amlogic/meson-gx-pwrc-vpu.c        | 2 +-
what's the reason behind including PHY and SoC driver changes in one patch?
I think both main directories will be applied by different
maintainers, so I believe the patch should be split into:
- one drivers/phy patch
- another drivers/soc patch


Best regards,
Martin