Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4247206pxb;
        Tue, 17 Nov 2020 15:46:03 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyEL//ECk5gSD7pDu7lMQ9X1c73LAQI/2dgrTh8MaWIcVyyyycTJ4h3k1C9Ja1BArJoun2M
X-Received: by 2002:a05:6402:783:: with SMTP id d3mr23641699edy.168.1605656763715;
        Tue, 17 Nov 2020 15:46:03 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605656763; cv=none;
        d=google.com; s=arc-20160816;
        b=bA2dFkIfdKpYolgJYH0jLZU+O+3ziQqfwNIRXXkXe6DnI+ZtOIbhnIzV7U7bQzy7BS
         eNucRLl4QVJMcDUyXZ8ASdEA1+r4u5bBCjuysUKOkZIFGa2nilFiMj9iQxcdP+ghUnEV
         X+FdwBctU6aM92eyu/T9oK/8W9Qyi/0AdeK0ebjyVGbTW4NGUZMIwpQK0X5haSNzIBQS
         DtgPDloWHFn48osOHg6zTzmCC1I+JkPTTzqhRmcOSJQzjjpS/lMLO094uDEW2fSx5q0J
         BerK4xNWFGrY/v5I+2eVUAq+EJuxQ4FyYStE59E2T8YzW7OoswV3WM5dC4UM9fReTruY
         +duw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=7YHR2e1/LHdcwbDfdQHbOVb5eFvzBWcfcNYNhAMGlwc=;
        b=hmwn/mx0MVSln4L2Y/HY5/Aahj916e01QyiM26lgxHZAEk98bs7AXjde8BgvG0Z3CG
         0lNd9ESH99Vv1U6yoeeyqN//yU797C8BFzhTm8ArOaB0i7Wilwo3Vn4AWgp0JZt+iUbQ
         nFoEPi5cwm8jo+0rSOtqxv/1r80RencU4/ZiFEeuA/3Whbeh0lOqEm529EjJWruM+ht+
         aZEzIqAu5TQApIqPArZ805sv1Sj3r0hm+EDYnhUoJOc/KN0J2Y8vDiPkVre2qOJJ7TL2
         LJqep2EvxSts7rgq1heLAI0/kSKJldIJ5wMpWwiMGkUshCKeUc9rakW/olR/DbMR8Kuo
         NBWg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Omh9HHcu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z5si14127573ejb.542.2020.11.17.15.45.39;
        Tue, 17 Nov 2020 15:46:03 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Omh9HHcu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726205AbgKQXnI (ORCPT <rfc822;huangweiredhat@gmail.com>
        + 99 others); Tue, 17 Nov 2020 18:43:08 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43480 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725774AbgKQXnI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Nov 2020 18:43:08 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5E0C0613CF;
        Tue, 17 Nov 2020 15:43:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=7YHR2e1/LHdcwbDfdQHbOVb5eFvzBWcfcNYNhAMGlwc=; b=Omh9HHcudW9qg6FCeuzA3BMnTT
        WSKVlVHr8w8CYJdKkd+A42tomHgdm/10sLe2wCJaVvNA24LQR5ORrq5zbBso2mhk0Hh7ZioA9QB1+
        cU7h2Y+dRQwcgIzGN42g27nSA5eUpoglHxgDRKuEKdXXa3WoWesnP1B3qzWVi+ZCBXSuk4VYDWlZb
        Wi57htRt0aTL+bxJfFbUxYOBB1RuMpTSUy6pAxSfRLUy9R2nNfsymiyp/aNear1MjdJP8VFTMF5aV
        1stbt+FhLGfRTVrWaeSZ2E/3jrxzN5IW15XYmCpWW04jet7hBK5TW7rFciFenQOAOTUViNLVCLcC2
        PG/I7chw==;
Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kfAco-000461-8J; Tue, 17 Nov 2020 23:43:02 +0000
Date:   Tue, 17 Nov 2020 23:43:02 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de,
        hannes@cmpxchg.org, yang.shi@linux.alibaba.com,
        dchinner@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP
Message-ID: <20201117234302.GC29991@casper.infradead.org>
References: <20201112212641.27837-1-willy@infradead.org>
 <alpine.LSU.2.11.2011160128001.1206@eggly.anvils>
 <20201117153947.GL29991@casper.infradead.org>
 <alpine.LSU.2.11.2011170820030.1014@eggly.anvils>
 <20201117191513.GV29991@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201117191513.GV29991@casper.infradead.org>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote:
> I find both of these functions exceptionally confusing.  Does this
> make it easier to understand?

Never mind, this is buggy.  I'll send something better tomorrow.