Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4276378pxb; Tue, 17 Nov 2020 16:42:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2fwpJRNSrw5Xq9VMClcOi4CEQgqikRo8ymB7WIXDVGs+0ZqNn+a3AvXtWCHrAAmbZVW6d X-Received: by 2002:aa7:d146:: with SMTP id r6mr22403213edo.268.1605660178778; Tue, 17 Nov 2020 16:42:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605660178; cv=none; d=google.com; s=arc-20160816; b=N7SLn81em3wfan2xc+zTXhZQkMYFDjSTOUIjUcjo0Kaq+oz/LjPLh9tgJE7Wae/aL8 bYzA+csZwGRrVB9Ruxy1gOq9TeF2hNxh/VqJfEffoW650FPKuGLD3BiKRzEN4FB+OHAy IVd32/jtP+c9pYihGeekVgqLNFUhAKgsfOMk5dv37N6VzJ0nk7NZvRu6FsjyC4IfU+Lt 1S/0/426Rdol8heuCvuvatxf4ig/4gT4110BrUgBlze3wHQgJcHjYn/8HYBdcowyXrnR bPoaJDd79bPEmB5Vdda52HekuaHCBz1zn/ONvWl2Vw0imVMB3TjV6SHLKm8xnyRijx3k ZnUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=fpRq5oGbKPQIWf1i8EYl3vqTi7XQsrMlJoxcyJpJKNQ=; b=RubRmaksxOCydYhEkRmOmc1IddZpNcCXP2TwTsINs4YjCuWbA3mdANUW7Wca2gY/tK SztwH+pmcZRapGLYZfglNJ6oxUNlS3doZ4oAp5K9+Z1Yiphl8hsdshHcLDostoHYJuRi YJWB5p55AytuR8hr3Fu+ZOauNkJzSfIi+ehkGDcR7e9pB7FwZSdcSnCRogFZ0Bq7W41M HR6nULXcTqX3pj7t07XqmZi3ziuzY837ljSRWjb4PZ+aqhWjH1x+jhKHs9jvN7F84KiN iL92JRk5B0jivo/svSeZl27jAVOUTtC2RVQqbg23zut8eTMyFGRUWjwIg2K2Yns6WWed UHFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rg9U2K7L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y2si2864315ejf.663.2020.11.17.16.42.36; Tue, 17 Nov 2020 16:42:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rg9U2K7L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727331AbgKRAkG (ORCPT + 99 others); Tue, 17 Nov 2020 19:40:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgKRAkG (ORCPT ); Tue, 17 Nov 2020 19:40:06 -0500 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B2A0C061A48 for ; Tue, 17 Nov 2020 16:40:04 -0800 (PST) Received: by mail-lj1-x244.google.com with SMTP id 11so435914ljf.2 for ; Tue, 17 Nov 2020 16:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fpRq5oGbKPQIWf1i8EYl3vqTi7XQsrMlJoxcyJpJKNQ=; b=rg9U2K7Llz1s3ghw9hvLqwjk2o3u9dU95otVL20eLEDgygNZpRsb/sSLWiOeDncl18 Z9ZlnNAKkQYzXBOzoP8p4066v9X8E+lkBlE9K6zlVwaGxNXB2daW6FoM23RSROU0AP+e l5UbRlaxteh1YV4DvoaortMefIJ9vEEfoFqOVkKapvJeO0XXBJa7At0YHa/xREuZGZDx V9cUUvpjLYKaA7j2BQOO5pkaY8eFkiEbNcnQfFo6Qo5a9O1hI5SiBYGhppQTvqSQcgrq PLaOQy/oTp8eDLPhB7EadrlRhfJ6FhdAbcYqUZM2iyYwFlIBD07wyxmXAjPZc08Dn1Yr DaDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fpRq5oGbKPQIWf1i8EYl3vqTi7XQsrMlJoxcyJpJKNQ=; b=lgQSIwhVv9if2W4O4jrM1Lh3RPaKs9137YuMDqs37EtUXryuviSuhdHdzQmk5WFlwS T3zHKXRrQxbGibm4u+rORly+QIi/TA51xtbev0QmDkRZ+It4UwP3k4yVtJa9TJkkW+Lv 1hx9YFF4LXBKEnq5HruPwLakqJwF66oin9uJcBfcE4gmNomYQtl/f4HSgHZzwyGqeUrb WihxCRewJ/kpjQOgOtxVatpMUv+tNB58+wEH429kqOr65bLocyfSVwtamqm1HI9Vtadz pXExRFk32hDWr0HGgIZHQRh0BOyz9FT6lXLAnAi94R84ml8AgKmEGGRlkcBkSabJz0oV fdqw== X-Gm-Message-State: AOAM530Ciy2zDPqAKN/EXSPcTmnKnPPQmDneP4Z0lXZTDEVecVWgHwS9 T+TBVr1bPJmfiK+PjMs2/ZwwTOOnjyH1hP99HpU/sA== X-Received: by 2002:a2e:321a:: with SMTP id y26mr3183401ljy.293.1605660002899; Tue, 17 Nov 2020 16:40:02 -0800 (PST) MIME-Version: 1.0 References: <1605201148-4508-1-git-send-email-srinivas.neeli@xilinx.com> <1605201148-4508-9-git-send-email-srinivas.neeli@xilinx.com> In-Reply-To: <1605201148-4508-9-git-send-email-srinivas.neeli@xilinx.com> From: Linus Walleij Date: Wed, 18 Nov 2020 01:39:52 +0100 Message-ID: Subject: Re: [LINUX PATCH V3 8/9] gpio: gpio-xilinx: Check return value of of_property_read_u32 To: Srinivas Neeli Cc: Bartosz Golaszewski , Michal Simek , Shubhrajyoti Datta , sgoud@xilinx.com, Robert Hancock , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , git@xilinx.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > In two different instances the return value of "of_property_read_u32" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "check_return" > Signed-off-by: Srinivas Neeli Patch applied. Yours, Linus Walleij