Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with
 multiply
To:     Bernard Zhao <bernard@vivo.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Monk Liu <Monk.Liu@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Yintian Tao <yttao@amd.com>, Dennis Li <Dennis.Li@amd.com>,
        Wenhui Sheng <Wenhui.Sheng@amd.com>,
        chen gong <curry.gong@amd.com>,
        Bokun Zhang <Bokun.Zhang@amd.com>,
        "Stanley.Yang" <Stanley.Yang@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
References: <20201118025503.102699-1-bernard@vivo.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <f55ec782-9eff-c30b-2a0e-01a9898c9387@amd.com>
Date:   Wed, 18 Nov 2020 09:17:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20201118025503.102699-1-bernard@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM3PR07CA0125.eurprd07.prod.outlook.com (2603:10a6:207:8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.15 via Frontend Transport; Wed, 18 Nov 2020 08:17:54 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: b70033bf-cadd-41b2-3dd6-08d88b9a740f
X-MS-TrafficTypeDiagnostic: MN2PR12MB3966:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB3966B469DD43F46E87E5E26683E10@MN2PR12MB3966.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:635;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: z8Omptn27fYckps9sXsR4NS8byNpiysTRlKhahDHmqaEKX6ISltzrCeMFH7Sfo7UA05N+zgYxBYoUtlctvHACjzwgkWTc/NftRgX6CcamF3HaIwIda4IniXg3nTcAnNMj2yQCA9FC7PAeUzjnkjRVVmiv2v8mfwpZLB1szgs9EeRJEF/dA5+hRWagHterCQ8JQw2USReNR4UoA4QbICdmIQeah6gLZO5dz4dpVCjjSIQwp5lOSQjq61lBqamfI8EcN73wZlvnRpWmWgSVa1uAj5jIW3DV9PvEguRyGeW/+p5VRQ0pg8R7+lJLqBzXHN6051Q2k7uvWfKuElixx1ktisTDIga7xgHZEsPF3BbWH/M58P2APAUMQ2aNfSieVUHkTfB5ai1KQ8ib8+rkiaj4Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(346002)(376002)(39860400002)(66556008)(66476007)(6666004)(16526019)(86362001)(36756003)(6486002)(31686004)(2906002)(5660300002)(66946007)(4326008)(31696002)(8676002)(316002)(2616005)(186003)(478600001)(110136005)(8936002)(83380400001)(52116002)(921005)(66574015)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UFlGTTZqNml4OThHOVZLQkc4VllXNFZiU0RFTURLZnROcXFuYUtZd1cvUGpz?=
 =?utf-8?B?VjAyOW5EQkthbFB5RWtHQmFLeVVWVmFzM2RDZGZTY1IyRUZNWUU3YmlpQSs2?=
 =?utf-8?B?UVlDNTFlMGdCb1BCMnBRcWZZS2JTUmJqMXFoL2ErUEVDR3ZhTnpYYm5kV2NT?=
 =?utf-8?B?a0hpWlUwOEJlb3IrakNnaGZnaDB5WDUraVd1b2ltMlFlMS85VmUzZTFZcEcx?=
 =?utf-8?B?MHhHRVJDd2FjWDJsWXY0TjNQN1plZFV0OTZTeVBBS3piZ3F6NjVsQVhpRVRU?=
 =?utf-8?B?SUlDcTNxM2ZTUGJtOG5QTmY1czZBWVU1S0xtakJQelN1RFJINVR5L3lhM1Vv?=
 =?utf-8?B?TFBVTHdkVXFWcmxTTGliVHI2VVFiK3MycU9raFByaGUyZkMxeC9WV0dGWGxU?=
 =?utf-8?B?cWo1Smg0K25lenozcU9pRmpucVRSV2pQcXBSYi81L0ZlaXpqL3Z0WVFYem94?=
 =?utf-8?B?R21jR3d0dFFkb1kzU01tZUdZbURoVW9OemNBNHRSU1lZbUxVd3gvc2VNVVNx?=
 =?utf-8?B?T0VWTWVBU3QrY29peHBzay9ZQk5pTlFLM2VxNmxwd2xVNi9sRTBtSG1XTTFQ?=
 =?utf-8?B?RFpqbXdOYWphcU0rbkltTndISzdkb1lvMWNxNGl0a1pDOW1IanBjeXI2dTRC?=
 =?utf-8?B?RkY5SzNiWGpodStaQms1RWdtRWdsdm5OaWhFclljaVBBcnB5SVpSbWVGOVNv?=
 =?utf-8?B?c2paVXRkaFJxTDF0UFdYY3ZVZ1o4V29zZzFGMXlZZ3ZuZzlZTkxoRW00bFhm?=
 =?utf-8?B?RmVhVXZLdk44WWxOOTFPYTJiNU9LbE1ERlh5Ry9UQlhZZTAwZktsMzVPbElz?=
 =?utf-8?B?WkdUaWRuYmljdlVCUlFEUE5TVWJZS2lQT0lJcy9XQzRYYzBGOGJFWC9GNGtG?=
 =?utf-8?B?d0VYUGJrNXpraXpIU1VIbGRpQXRINVA0NUdKWndOaDdWUWYyL2lQM1UzNHRr?=
 =?utf-8?B?WnZVTnlOdmtNMStpSVFDUy8rTnBDbnA1REM5YnJsOXlNaUlhS2ttZHRycEhQ?=
 =?utf-8?B?OFNTWmZOZ2VxVGdaMnprVWcyYnBsd3ZlR0lJcnhMVjFRRENPczltdVlLeENY?=
 =?utf-8?B?T1MwWERpZVRLSG9kcDhnNHArT2N1Q3BEQTZIYTVXOXA1elJCS2hTcDJpcjdy?=
 =?utf-8?B?bmVGVTJHWVNMY0lwMjRScGRibURGWFVrY2hEQ0I4RWNsSDFzWHRLK2hTcXo2?=
 =?utf-8?B?U2NUQmVKS0ZFZlBjQnFmRlR3aEw1UXZrc2NUSVYvRzVWcC9PMjZWRkNXVjB3?=
 =?utf-8?B?ZVpIQ0YwR1BON0tEMGViODJ1bEpsRkMvWnFFL1k4aW90MVptUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b70033bf-cadd-41b2-3dd6-08d88b9a740f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2020 08:17:56.4323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oJ2Qw9L69cTpTUEBZyuLUhNtCtl4mcNJIYa2PoG7NM49UgUzPjuUvVXYkwm3LFXj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3966
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.11.20 um 03:55 schrieb Bernard Zhao:
> Fix check_patch.pl warning:
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> +bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo),
> GFP_KERNEL);
> kmalloc_array has multiply overflow check, which will be safer.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Not userspace controllable values, but looks cleaner anyway.

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index d0aea5e39531..f2a0851c804f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -280,8 +280,8 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev)
>   	if (!*data)
>   		return -ENOMEM;
>   
> -	bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> -	bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KERNEL);
> +	bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL);
> +	bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), GFP_KERNEL);
>   
>   	if (!bps || !bps_bo) {
>   		kfree(bps);