Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp244238pxb; Wed, 18 Nov 2020 03:28:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYNn+T7pULmNNdZT4MFXWCvG7omcjIU8+Y4hm3Gtgp2gOyWXfxPcSdQ0KWjhPkodJ0QweB X-Received: by 2002:a17:906:d149:: with SMTP id br9mr11358585ejb.460.1605698933123; Wed, 18 Nov 2020 03:28:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605698933; cv=none; d=google.com; s=arc-20160816; b=xC/PGV8SErcMG9+BKtQ1oChw4iU6NkUOWNHZqZ/DEXqmfQOiyCU1Tmng3Rm4kOEheX jBohSZcDS4oI1rZoqDIkgEglToFK06E+hocYltAg4xHUQVEvZVUHPP36Mk6F4fvgDK7E +SIFINVWOspOMcjN1saa4Qs4z9cL+ZSArG098NvVsb1DkRJ0Bxsl7ZF6kDjWJYbJqRPB 1iFRHLEsFsEXL/3u/X9IcxVfzKbXCc2PJ0fFI+DrfG0FrI1CbOiU+IsTVnGdMkVuyF1m eK3bpNauL8A8IX8HWMOoHqPrAzfg6dGc3+UyR0+iaoG3a40md6tVKArGPhz++H7qPgT6 70jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=TUjCCZUUH8OLh6XZB6NhWxcK+9KqFaUWGef66hapmRY=; b=pz2JH4xsOBzW1iW31q4sOzKj8Eh/eSykwtGAa+ZMDPO8o/kT3qeemm4sypJeiAC+WW nNhNH0pigRtBY4mGFgYTo/RKHQw5VzUJnUB5rwfZQ6V3IRLNy+BmBi4oG2ViuobZY13x ArdglrnZh5bYGwTDFrXj1wxp7sb6XeHxHmlmK5a4VtzAahHL4ykmMZp0pnvBHYVp244g bKRSZWg5EmVaAVOPhjAMyOFP7USLTVi0mMAoR3Q1938twy/x0oKWsCIOMrLZG5b5x+Az wYjqeZr/lWAzaWf6w9QJhU/ByqzijFMXg6dQmPz/ndxsgjdmBtIXM32JhUOf9tj9lFh9 z37Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=hZrIzEPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si17047729edk.386.2020.11.18.03.28.30; Wed, 18 Nov 2020 03:28:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=hZrIzEPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbgKRLYn (ORCPT + 99 others); Wed, 18 Nov 2020 06:24:43 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:2269 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727187AbgKRLYm (ORCPT ); Wed, 18 Nov 2020 06:24:42 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 18 Nov 2020 03:24:32 -0800 Received: from [10.26.72.203] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Nov 2020 11:24:39 +0000 Subject: Re: [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator To: JC Kuo , , , CC: , , References: <20201118034631.74127-1-jckuo@nvidia.com> From: Jon Hunter Message-ID: <6e21646a-a687-65b7-cd69-2c15e29e8241@nvidia.com> Date: Wed, 18 Nov 2020 11:24:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118034631.74127-1-jckuo@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605698672; bh=TUjCCZUUH8OLh6XZB6NhWxcK+9KqFaUWGef66hapmRY=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=hZrIzEPeYhFGw4XLwx/xe/xVyM5uCQRQCHsl1+ykjNO8At70Fscu6wgAd67OpdQHi tXpb4gX05KvY9UMGEtcDop+4Jz7B3KYeqziSlNkab29jyU9/GVv51WoAOrE2homzHz D/+VjIQgjQ+wOGu+CC4PHmfhmSTDACuU0RWZ9IXSaDFaF6DoEm6llOiyRMroh+KXUd mDgTY2nFbrG3UG/z00vYuhV2GMbbng3Z/BdDhrppXhq7oF3P9xLc6OjHObB9/nFgRB 0E4yur7zNwGZk/n7rI3cKfXy5eh3E20Du0awTw/dLMjEsJLI6fBQgM0w9NOlpqJPT5 GcXibjsIO6o8w== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2020 03:46, JC Kuo wrote: > USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2 > regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14. > > Signed-off-by: JC Kuo > --- > .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi > index e18e1a9a3011..a9caaf7c0d67 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi > @@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 { > vin-supply = <&vdd_5v0_sys>; > }; > > - vdd_usb_vbus_otg: regulator@11 { > - compatible = "regulator-fixed"; > - regulator-name = "USB_VBUS_EN0"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>; > - enable-active-high; > - vin-supply = <&vdd_5v0_sys>; > - }; > - > vdd_hdmi: regulator@10 { > compatible = "regulator-fixed"; > regulator-name = "VDD_HDMI_5V0"; > @@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 { > enable-active-high; > vin-supply = <&vdd_3v3_sys>; > }; > + > + vdd_usb_vbus_otg: regulator@14 { > + compatible = "regulator-fixed"; > + regulator-name = "USB_VBUS_EN0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <&vdd_5v0_sys>; > + }; > }; > Thanks for catching this! We should add the 'Fixes:' tag. By the way, I assume that VBUS is currently broken for the OTG port. Without this change is that USB port completely broken? I am wondering if we need to CC stable@vger.kernel.org on this. Reviewed-by: Jon Hunter Cheers Jon -- nvpublic