Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp376012pxb;
        Wed, 18 Nov 2020 06:50:29 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzyFZU1+rFXHHBVBxRcBA14pftahzEwvbKbsKFoYIHjSsC8Mo+sBmm6xeJd5cCs0g/dTOpH
X-Received: by 2002:a17:906:3087:: with SMTP id 7mr23591707ejv.375.1605711028926;
        Wed, 18 Nov 2020 06:50:28 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605711028; cv=none;
        d=google.com; s=arc-20160816;
        b=svidw7nifJpkZLXRg+tBIBne9jtVy461x0jFlt8nF85OcfCkEEZp2TQTi5URcYy1Le
         cGaDrHpKBygdlHyHpn4AqDWb8Q/JO2XBBsQBeGnCaEgkuKBNdMXTIHtL3P673Yp84Igv
         13IryXZLEHt3Srk5lIunZMIm5iYW/65GmwunctHN7+qiZqazSCdt/FE8pIH+MGiIFgHi
         T36y9qKLEwJGRcUjanVM9M1zTTCxjw5QKfiLfiND8NI91cr87GRzmbL+ru7DNg17CObb
         n+mlMqJcMJXiOUUHZFzigWKMjDL7+8Q7v7mlbfVgy5jEepW0gvDG5JPLEL0P7Kf5hUYv
         VC6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:mime-version:references
         :in-reply-to:message-id:date:subject:cc:to:from;
        bh=ePpcn4keTqHeYJe7Bo2sIdBFTSQVj6QSpdB6WzWqwI4=;
        b=UbWYO6XpKa8OWIxBmhWQa5+ajTDB/hQFUsKjYq49qIgZkgEjhHidgAWxuWdgpeXPmj
         aZHWPucQt+MnbNYOR0fkZehz2+sbX3slmHuyhQE3zxdW6RBynQQrpogQMN9jn8vCzJnl
         AyMlCXgtgCD9/XmTTqouGt8KvotjKUdKD5Eculal6bUNP98NlGljNnlFlc2ymfJvsm4F
         pX68HKo6E8KdSCciRdwRvQ7QSrfSkGBeHsVMnEPMBwPQlJNAh4hopsaupa3sRSy5IXxJ
         +WM7vLvTiSPnHbi28eI3pQgtwNtwTi3s53sNsq2RD0VmXATPH6vkcbUKImsJ1T2dMo9a
         Jzhw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=ZMQQFi23;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e15si16280544edy.389.2020.11.18.06.50.04;
        Wed, 18 Nov 2020 06:50:28 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=ZMQQFi23;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727134AbgKROqm (ORCPT <rfc822;huangweiredhat@gmail.com>
        + 99 others); Wed, 18 Nov 2020 09:46:42 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:5344 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726306AbgKROqm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Nov 2020 09:46:42 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fb533c80000>; Wed, 18 Nov 2020 06:46:32 -0800
Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Nov
 2020 14:46:39 +0000
Received: from vidyas-desktop.nvidia.com (10.124.1.5) by mail.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server id 15.0.1473.3 via Frontend
 Transport; Wed, 18 Nov 2020 14:46:35 +0000
From:   Vidya Sagar <vidyas@nvidia.com>
To:     <jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>,
        <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>,
        <amurray@thegoodpenguin.co.uk>, <robh@kernel.org>,
        <treding@nvidia.com>, <jonathanh@nvidia.com>
CC:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kthota@nvidia.com>, <mmaddireddy@nvidia.com>, <vidyas@nvidia.com>,
        <sagar.tv@gmail.com>
Subject: [PATCH V2 1/2] PCI: of: Warn if non-prefetchable memory aperture size is > 32-bit
Date:   Wed, 18 Nov 2020 20:16:25 +0530
Message-ID: <20201118144626.32189-2-vidyas@nvidia.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201118144626.32189-1-vidyas@nvidia.com>
References: <20201118144626.32189-1-vidyas@nvidia.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1605710792; bh=ePpcn4keTqHeYJe7Bo2sIdBFTSQVj6QSpdB6WzWqwI4=;
        h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To:
         References:X-NVConfidentiality:MIME-Version:Content-Type;
        b=ZMQQFi23Nxd2MCMeTWa3zs2UduEDQO+QiUJGFZbekcAnsvNJguigdLIpgBTSO9zV0
         HnAzf8ntV1j0HOIwQ0XlbXKvMdvxxQMODo7VlQ1BUXaDMb5rAauyd9avrJSmr/WnWX
         AbWTwxQZWh3knPxW3YJ3hJUVdudoWjcc29WgPObfhf7XMiAFn78gxkhCUCUtIJOUN9
         sdBwdXeisQev/iSkuO4HAYzF0dYm5uVCkbSLwWiVpYnK8XgCYups7LHtPbGZVautcD
         7SS2fn+MaRBBcJsRIKR4EqQ4pPTgnXQHlECcoaGRnvCVZ5f5GMve//yrG1OsHDp9je
         /dW+QFjIuR/tQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As per PCIe spec r5.0, sec 7.5.1.3.8 only 32-bit BAR registers are defined
for non-prefetchable memory and hence a warning should be reported when
the size of them go beyond 32-bits.

Tested-by: Thierry Reding <treding@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
V2:
* Added 'Tested-by' and 'Reviewed-by'

 drivers/pci/of.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index ac24cd5439a9..5ea472ae22ac 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -556,6 +556,11 @@ static int pci_parse_request_of_pci_ranges(struct device *dev,
 			break;
 		case IORESOURCE_MEM:
 			res_valid |= !(res->flags & IORESOURCE_PREFETCH);
+
+			if (!(res->flags & IORESOURCE_PREFETCH))
+				if (upper_32_bits(resource_size(res)))
+					dev_warn(dev, "Memory resource size exceeds max for 32 bits\n");
+
 			break;
 		}
 	}
-- 
2.17.1