Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp413441pxb; Wed, 18 Nov 2020 07:41:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+frv3wxAuujMlsBYho6BezhkAHLwUPhgTaasEeCOgod7vnvTeSJ12CQC5W1SkKwr49whq X-Received: by 2002:a17:906:2c19:: with SMTP id e25mr20598479ejh.66.1605714107990; Wed, 18 Nov 2020 07:41:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605714107; cv=none; d=google.com; s=arc-20160816; b=u1B/Wce1m60H5zWUD7VYlhw7XXjD0wi1cg9ARXybD97Vz9NenJfwdS4vjmQK3zcy+9 +czqpJLRQ+tlRPHMIPvO5LzMhq8FwuM1Egm5/rah6IIZXnJ1uwKwVRtNjvxLXw8l+6mH XGe3rPmYFpm+PNeIZ2rTqZTwFSJRleG1jgFe8gJaAr8UvM4x0Env9Jg3ODyR6mG6aaOA SNTYGwhnN3/GHp/tlkVbLOWtMxciaaczRhliPaSj6cmWHHOzCu4dU7tmGgbYTxVQHRJd NP906osHaOUtvTCuYoIsmRQYkDTx0HHrHibADJSmmROF8Wvy42pqnJRIIogxo/5flJrx deZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=x4uO1ZuZIrJiF7QiCN6K5UF0mU70q5CXvCZ3IEy5VII=; b=Q6NPbMJ/+ewDMpnCrsNPdLXiqGPu+AT9r5H5bdKvKEs4bz4xB97lwuIuUTUAuvzypX jnxBVoVeSRyMs9R7Nt3xEFUClrf1MNAJNWeUnjNo8mMMTtU4tCry4iMU1zcCRjS6Qsou RHjevZT1UIY1L1icq6WlEO1W/d3UuBU3TIpfYq3azIjMovNlVxBADUDQ7NI1HEG31Pw2 GyCxouPEDdYnrIZpDw+ZxBzDFjNrdHz38dGx2Zh7tU/WIaYan6gx31f3mnPcDkv0Sy/H JYZMzn2mqHl87JEnuEIxjxNJW7rzcJsDc+smFkgBzcU7QzqOMVc+NMubzN6Dy03W3DJV EOwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=kFGMzxHT; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=CFuKqTIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si18365900ejb.290.2020.11.18.07.41.23; Wed, 18 Nov 2020 07:41:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=kFGMzxHT; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=CFuKqTIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgKRPhi (ORCPT + 99 others); Wed, 18 Nov 2020 10:37:38 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37393 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgKRPhi (ORCPT ); Wed, 18 Nov 2020 10:37:38 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D5F0D5C017E; Wed, 18 Nov 2020 10:37:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 18 Nov 2020 10:37:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=x4uO1ZuZIrJiF7QiCN6K5UF0mU7 0q5CXvCZ3IEy5VII=; b=kFGMzxHTjtd5zKVqlwN2ZLiLbw4sWfjFL0MIM/RHG45 n/3gMBFw/Fc6sEGIHfK5GytsTqarnevR2LkRkhwaQWmHu1rw6xB5wCws2UmudbXl 1wqBeTNleTYsL2k6054nw41GhntP+ZB6k2mqxJstKnYggGk6RAtLVQgITvh349JK 4/kzJw+QMlUIwMzQmuJrESZSkVU00YW1bPufyHHpVWiaLKPTT+Oc3P2lX00AyR6v aEaopc97G3YnP2fSpJsAYH/+MGEkgI+uAtUlnNae2eXmE/2FgI4yBhdCpViUJXhc 56wExRTVBJceufts1fM10PttfepIM1L/88DKJBlKbHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=x4uO1Z uZIrJiF7QiCN6K5UF0mU70q5CXvCZ3IEy5VII=; b=CFuKqTIn/e6GzGqrSAEQxo kBMtXrEPlF79p1uSXYeib644DK8aXh0qrc9hR7UaMPt4hblnzFfBYH5naQx9FRcJ T+0q2jQyh8UOFHj7yv4pDA4Hn9Qp/22+jpka11QQIDlc7UqfsPgrW+RJalJRaNca iYqPVfJk7/aPKnM9LdSoja7zYUjdzJB+gvxbmTs+MKGtUzrp25B5XLrWc919NwMR JTL/1Pf0b7/c54D0E/5Q5J7nG4B8uLVX4f0kMoWL8FcZo0l0UVlDLerHNzwonD36 2td6oAW71ZFbXDUAh+T+8sE0cKC1o369xEP4l9jSggZbAXbWYe+48AqyCD4Qb35w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 256CA3064AB6; Wed, 18 Nov 2020 10:37:35 -0500 (EST) Date: Wed, 18 Nov 2020 16:37:33 +0100 From: Maxime Ripard To: Wilken Gottwalt Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Chen-Yu Tsai , Jernej Skrabec Subject: Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support Message-ID: <20201118153733.jgiokn6jkwu6rv6c@gilmour.lan> References: <149526a0ba8d18ebb68baa24e95d946ede90b4c0.1605693132.git.wilken.gottwalt@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ax5hpchws2jve5tb" Content-Disposition: inline In-Reply-To: <149526a0ba8d18ebb68baa24e95d946ede90b4c0.1605693132.git.wilken.gottwalt@posteo.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ax5hpchws2jve5tb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Wilken, On Wed, Nov 18, 2020 at 11:02:40AM +0100, Wilken Gottwalt wrote: > Adds the sunxi_hwspinlock driver and updates makefiles/maintainers. >=20 > Signed-off-by: Wilken Gottwalt A more descriptive commit log would be welcome here, for example containing on which SoC this driver can be used, and on which it was tested. This is the third attempt at that driver, and you can find the previous versions here: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20200210170143.= 20007-1-nborisov@suse.com/ https://lore.kernel.org/patchwork/patch/706512/ Most of the comments on those series still apply to yours. Most importantly, this hwspinlock is used to synchronize the ARM cores and the ARISC. How did you test this driver? Thanks! Maxime --ax5hpchws2jve5tb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7U/vQAKCRDj7w1vZxhR xQzvAP9APC8fwWSCTOQ9an+HbUMCocME/0N1wG/KKU2fHt630gD/VTfNUcWHoxXM h6KGAD6e1roJ7j2sNMmziTrSvx9sHwQ= =hUYy -----END PGP SIGNATURE----- --ax5hpchws2jve5tb--