Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp435349pxb; Wed, 18 Nov 2020 08:13:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyYZIcEOe3L+Dy3OidKP7qTRcSgtTSnzY9kpkAklAoxIgIESy6+AxuXCohC6em6DPvyQJp X-Received: by 2002:a17:906:b01:: with SMTP id u1mr25413333ejg.427.1605715985826; Wed, 18 Nov 2020 08:13:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605715985; cv=none; d=google.com; s=arc-20160816; b=IAr+c7vol0JE4Y6tmx2pZVLllaG4Z1BdqRsQRTCvPHyhMI5Tm/9XQUJE6yO/kz+mXB nQNFp1ZiW3oDyca5dHp5ZF/yjGYqKOi7EAHRq81JfF/QOei/MluEP1yYQi2onOh8l4Y1 MGyQ9PN/bXhD/xteSHghCMmf0R5h+E4MpZclSrM2YQZV/7fBIvbIXENmFyXK/jxPBTMG zVAVJVhY2SUc98ZrYYXeeMaRi7TTYUHAENmgM5F8iueNwRu/qhZJaqU7VaQ00Xd0dKQ3 rpnnNdkcQf0EqcqNCP37OPyFB1/w1Q2Gb/G+BDAz6qgY+Sr+GR10wxDRvk5ATgMTT1uV 5/JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3BqNy/tQG7myMKclUBJ2s6npPTjs5n4WYRwYHbVNyVg=; b=sFKOeYZ9TenT3x3D8T5g/7MJL9Pi0RY3UVoLrfyeUmcj2dq5yAc99HF8RiT8C0RjaN l/3jIdtXo3yeCQTNCWX/pfc2t4tZ7+Bgc6dn8RzqvngsoT2Mosr/+Bhshiziw+9KHG5/ ZbBxK9k545HrEDCRVh26PW7FUzZdWW3L28xN9UAmInyVneK+mFRdPsKBuBGPfNoWfe1P 0nrX8a8tYNE9Dkjn+zcfRvhOh0uDmzYbQhOXhYPy+OB/O3Z4nIOA+HfQ3Pk/Y0m3QfJ0 EnkC22BOkMdN1QHNLk79zgOyRzCISXxyI62iHhYSj6KTr5sRlJ6BdU/Q22D83qquUXmd mwxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H0igNk9D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df7si20711715edb.44.2020.11.18.08.12.37; Wed, 18 Nov 2020 08:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H0igNk9D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726584AbgKRQIe (ORCPT + 99 others); Wed, 18 Nov 2020 11:08:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52394 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgKRQId (ORCPT ); Wed, 18 Nov 2020 11:08:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605715713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3BqNy/tQG7myMKclUBJ2s6npPTjs5n4WYRwYHbVNyVg=; b=H0igNk9D22aRDIXjT80KIsZeTlGDFjxnxGHk7nQqSXrYqUYlavH9TfP2jTeC2/kwUTdS3L VaRAGkohIXOO0O6eYbii3f8/L0xcBH3duLLBZqD1OINoKw/O4S5g3MRwk107f52n3re/kU AVO2igNYVhqUNdkTa0moeaqCAtkULNI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-DZfKV5YgPiWbLUBe-DMavA-1; Wed, 18 Nov 2020 11:08:28 -0500 X-MC-Unique: DZfKV5YgPiWbLUBe-DMavA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5241D814608; Wed, 18 Nov 2020 16:08:27 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4ED25DA7B; Wed, 18 Nov 2020 16:07:48 +0000 (UTC) Date: Wed, 18 Nov 2020 11:07:48 -0500 From: Mike Snitzer To: Randy Dunlap Cc: Christian Borntraeger , linux-kernel@vger.kernel.org, Mikulas Patocka , Alasdair Kergon , dm-devel@redhat.com, Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org Subject: Re: md: dm-writeback: add __noreturn to BUG-ging function Message-ID: <20201118160748.GA754@redhat.com> References: <20201113225228.20563-1-rdunlap@infradead.org> <344abf76-9405-58ba-2dc4-27cab88c974d@de.ibm.com> <20201117163147.GA27243@redhat.com> <20201118154944.GB545@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118154944.GB545@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18 2020 at 10:49am -0500, Mike Snitzer wrote: > I don't think my suggestion will help.. given it'd still leave > persistent_memory_claim() without a return statement. > > Think it worthwhile to just add a dummy 'return 0;' after the BUG(). Decided to go with this, now staged for 5.11: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1