Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 18 Nov 2020 10:48:58 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Simon Horman <simon.horman@netronome.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        "David S. Miller" <davem@davemloft.net>, oss-drivers@netronome.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] nfp: tls: Fix unreachable code issue
Message-ID: <20201118104858.283cfd87@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201117200646.GA10136@netronome.com>
References: <20201117171347.GA27231@embeddedor>
        <20201117200646.GA10136@netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 17 Nov 2020 21:06:47 +0100 Simon Horman wrote:
> On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote:
> > Fix the following unreachable code issue:
> > 
> >    drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> >    include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
> >      208 | # define fallthrough                    __attribute__((__fallthrough__))
> >          |                                         ^~~~~~~~~~~~~
> >    drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
> >      299 |   fallthrough;
> >          |   ^~~~~~~~~~~
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>  
> 
> Reviewed-by: Simon Horman <simon.horman@netronome.com>

Applied, thanks!