Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp548156pxb; Wed, 18 Nov 2020 10:54:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqOloOdBD6d2Zj4RMHMovss/FjJowtmr+L8jLTQXPP4sAbaKOXcQMJl7nAqTKkJaqWLk7e X-Received: by 2002:a17:906:b312:: with SMTP id n18mr26069447ejz.353.1605725642309; Wed, 18 Nov 2020 10:54:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605725642; cv=none; d=google.com; s=arc-20160816; b=Ik6wQ8wfnoDd1wKH+0/o0DUJ2u/A1ARlsK3IpR3vB2Z+Psbzfps6pVmkkhcsQSk7Mi +4cVVfPedIPaoCHPJhtqJkW2DZzyKAYAXvfjPIxYzZ1lMXkonrRinHKYb6RptLskR6zz Xy950bJUgZvSgfhsFYv0Uhr9obdYQs5ubvnwAEhN+J53K/bMegR4bffp9OODZovjpaog KCxkAM8nPHq+6EesbA1NUjLOj9XQ5s8kmcQwW8lrgcnGmb7AmfzIdqHCJmWI3oC9/IMc 88vGIS+BvLKD6N/J292d7WdgubY1ANtsawenCyk5xcit/dqJqrvyVsNtEMrhYlmaualN 7XPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=XErRQEOY8TfA3Ruut6+eTvbSEvMOzO0sLIWx2VgpvyI=; b=1Avccr9+b4dGN8hGwl1v2d/hii8xgJIj54yXqpPNBGeLPvshxBYx4Oou7pkO0+84O5 a8kHKyoFHyIC11xANCXM117QO+MDz2DXqkr9C1KvJqbh7v63SuUEEkafgFzQ0tj5zC+l 2+uvaTkcElPRptsiNS3N2vo5SHWfN8yEpFdeKBqxCOm7OmUZVmFClrS3daJuL6MxM1Km RmiW7znCgi1gkkpPMn6eeOnFO40hjGdwtiI6RvQhFo0KvzdNYoIQWWRJt2rY20KnKWJm 4jg4uvy7GjxF/5qtd9JzUIAE9bTrRGWAqSfr6oL2lqz0sgpIR7ar1/PI4OpDguCqDCpJ HsNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="bFh/p/VU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si17287778eji.422.2020.11.18.10.53.39; Wed, 18 Nov 2020 10:54:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="bFh/p/VU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbgKRStn (ORCPT + 99 others); Wed, 18 Nov 2020 13:49:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:56382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgKRStm (ORCPT ); Wed, 18 Nov 2020 13:49:42 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A10D8246B9; Wed, 18 Nov 2020 18:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605725382; bh=UgceN5sO4JwwPCASJv0qKdvFM3Z0kpl0YVr5qTEc694=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bFh/p/VUOc0Z5RM3ZZ+BVl6yzjLUYphdAxb8ge1SBWBFqGt0T7tfGatIgzKX/64/q DnJoqd2y2z+1NWStniYyY3YkwXNCxvmGpfZE0dwbF7REAJMrKKd4ol4Hx2K24N+ays ZBDpqN8VkeQzADLB6tr/diXJo6wWWdhGV+5B0Iq0= Date: Wed, 18 Nov 2020 10:49:40 -0800 From: Jakub Kicinski To: =?UTF-8?B?QmrDuHJu?= Mork Cc: Filip Moc , linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400 Message-ID: <20201118104940.19996e94@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <87d00bu6uc.fsf@miraculix.mork.no> References: <20201117173631.GA550981@moc6.cz> <87d00bu6uc.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020 20:22:03 +0100 Bj=C3=B8rn Mork wrote: > Filip Moc writes: >=20 > > LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set. > > > > Signed-off-by: Filip Moc > > --- > > drivers/net/usb/qmi_wwan.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > > index afeb09b9624e..d166c321ee9b 100644 > > --- a/drivers/net/usb/qmi_wwan.c > > +++ b/drivers/net/usb/qmi_wwan.c > > @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] =3D { > > {QMI_FIXED_INTF(0x05c6, 0x9011, 4)}, > > {QMI_FIXED_INTF(0x05c6, 0x9021, 1)}, > > {QMI_FIXED_INTF(0x05c6, 0x9022, 2)}, > > - {QMI_FIXED_INTF(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD L= TE (China Mobile) */ > > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TD= D LTE (China Mobile) */ > > {QMI_FIXED_INTF(0x05c6, 0x9026, 3)}, > > {QMI_FIXED_INTF(0x05c6, 0x902e, 5)}, > > {QMI_FIXED_INTF(0x05c6, 0x9031, 5)}, =20 >=20 > Acked-by: Bj=C3=B8rn Mork >=20 > This fix should probably go to net+stable. Done, thanks!