Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp623271pxb; Wed, 18 Nov 2020 12:50:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeW4TTp/IvTu5zlr9/SHpPp6l71Kg0sU+nTWqYK4fZqzBC+LONZzX96qmPg9xgjG9C/+di X-Received: by 2002:a50:fa92:: with SMTP id w18mr26848024edr.44.1605732605575; Wed, 18 Nov 2020 12:50:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605732605; cv=none; d=google.com; s=arc-20160816; b=T7k3fauW3/jK/vscfcnaCou2sG6Bcp48wKJLHCp6CtyKhfNTiAwDtsw7qXfrxl0DBZ 75Ou1zfUurUg+92ZkfQiNJQidNCvyDN08dlQ3qDCXcNV5efjAT08KWE0pSybeNau8V2+ Uy3YRrxVro13loKPMA6WejMi4usqMh1walTeRWuquq6X9TIYQ6QSsAm+NAmvSL0jngQK mxuCunypQQdys9Kyb3Q+VZs9T/4lebzR76x1I2iqqyE6xE7gtVVEPonOxrENeRIvKYSQ TjBOgHmsCJVm1EE5Pe0+C0euIOQZzPVs8xlXxaR414HZzblGPMiGvYQ2TDx0XkUchCWt GkbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=XaoHFdwBSzRTMYjF3cOBj9S1ujSf9RP1UDhvxlrfA2Q=; b=zZKnK+ENJ7xgiUrPAN43nmiQJ15ntSCbXCQETFsTFrYsFBUY2VksD7nTK0dWhv88JD 3J36KCuEdnS3ObgR587GPa2g3qOYpgUCNQmSuVrAuh1dRPy1+7kIInUfPOKukuNuK2R7 bJxkwYZ9giJc7gXbttBSabc2ll6KqTiEZfryvBlILj98kQ/xmi+8MZibrYYt8BHtAFvD LDVCr9Fa+vxlcjaqoe2CkIMdOTaxSQEVnRzWr5zq/w3XJDFpoLY9aW3RyQIsfchwOuX3 vf0XVGc5WXDYwzblEk5P4ZYtBRxExqYZICyh8B5NObf7IBwZSYxG7oGDr1jf3hrIpEGn Rj7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p25si17148332edq.230.2020.11.18.12.49.36; Wed, 18 Nov 2020 12:50:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727342AbgKRUqc (ORCPT + 99 others); Wed, 18 Nov 2020 15:46:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgKRUqb (ORCPT ); Wed, 18 Nov 2020 15:46:31 -0500 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E72BC0613D4; Wed, 18 Nov 2020 12:46:31 -0800 (PST) Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id D92282EF; Wed, 18 Nov 2020 20:46:30 +0000 (UTC) Date: Wed, 18 Nov 2020 13:46:29 -0700 From: Jonathan Corbet To: Alex Shi Cc: Andrew Morton , Yang Shi , "Kirill A. Shutemov" , David Rientjes , Zi Yan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs/vm: remove unused 3 items explanation for /proc/vmstat Message-ID: <20201118134629.31b3cdf8@lwn.net> In-Reply-To: <1605520282-51993-1-git-send-email-alex.shi@linux.alibaba.com> References: <1605520282-51993-1-git-send-email-alex.shi@linux.alibaba.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2020 17:51:22 +0800 Alex Shi wrote: > Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success > stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs > still has their explanation. let's remove them. > > "compact_blocks_moved", > "compact_pages_moved", > "compact_pagemigrate_failed", So a quick look says that the above-mentioned patch didn't remove those three items; two of them were, instead, renamed. Rather than just taking out the old information, it seems we should actually update it to reflect current reality? Thanks, jon