Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] docs/vm: remove unused 3 items explanation for
 /proc/vmstat
To:     Jonathan Corbet <corbet@lwn.net>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Rientjes <rientjes@google.com>, Zi Yan <ziy@nvidia.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1605520282-51993-1-git-send-email-alex.shi@linux.alibaba.com>
 <20201118134629.31b3cdf8@lwn.net>
From:   Alex Shi <alex.shi@linux.alibaba.com>
Message-ID: <4e4931f5-ee46-98c2-38f2-3e8d1f515b44@linux.alibaba.com>
Date:   Thu, 19 Nov 2020 10:10:29 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201118134629.31b3cdf8@lwn.net>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2020/11/19 ????4:46, Jonathan Corbet д??:
> On Mon, 16 Nov 2020 17:51:22 +0800
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
> 
>> Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success
>> stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs
>> still has their explanation. let's remove them.
>>
>> "compact_blocks_moved",
>> "compact_pages_moved",
>> "compact_pagemigrate_failed",
> 
> So a quick look says that the above-mentioned patch didn't remove those
> three items; two of them were, instead, renamed.  Rather than just taking
> out the old information, it seems we should actually update it to reflect
> current reality?
> 

I thought about the replacement, but there are couple of migration events
have no explanation:

#ifdef CONFIG_MIGRATION
        "pgmigrate_success",
        "pgmigrate_fail",
        "thp_migration_success",
        "thp_migration_fail",
        "thp_migration_split",
#endif

It's better to fill them together, also change current explanation accordinglly.
but I'm not so confident on this now...

Thanks
Alex