Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751088AbWHXKvO (ORCPT ); Thu, 24 Aug 2006 06:51:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751091AbWHXKvO (ORCPT ); Thu, 24 Aug 2006 06:51:14 -0400 Received: from mtagate4.uk.ibm.com ([195.212.29.137]:53910 "EHLO mtagate4.uk.ibm.com") by vger.kernel.org with ESMTP id S1751088AbWHXKvN (ORCPT ); Thu, 24 Aug 2006 06:51:13 -0400 Date: Thu, 24 Aug 2006 12:51:00 +0200 From: Heiko Carstens To: Gautham R Shenoy Cc: rusty@rustcorp.com.au, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, arjan@intel.linux.com, mingo@elte.hu, davej@redhat.com, vatsa@in.ibm.com, dipankar@in.ibm.com, ashok.raj@intel.com Subject: Re: [RFC][PATCH 2/4] Revert Changes to kernel/workqueue.c Message-ID: <20060824105100.GA6868@osiris.boeblingen.de.ibm.com> References: <20060824103043.GC2395@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060824103043.GC2395@in.ibm.com> User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 22 > @@ -510,13 +515,11 @@ int schedule_on_each_cpu(void (*func)(vo > if (!works) > return -ENOMEM; > > - mutex_lock(&workqueue_mutex); > for_each_online_cpu(cpu) { > INIT_WORK(per_cpu_ptr(works, cpu), func, info); > __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), > per_cpu_ptr(works, cpu)); > } > - mutex_unlock(&workqueue_mutex); > flush_workqueue(keventd_wq); > free_percpu(works); > return 0; Removing this lock without adding a lock/unlock_cpu_hotplug seems wrong, since this function is walking the cpu_online_map. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/