Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp244356pxb; Wed, 18 Nov 2020 23:12:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTpKXMkX9u+CjLyjpOiWnDidl+V0mJgJOAQmLKshGYNBMLHQp8tU9yG/W+U0IBd1v5asQb X-Received: by 2002:aa7:cc8f:: with SMTP id p15mr31128214edt.240.1605769973704; Wed, 18 Nov 2020 23:12:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605769973; cv=none; d=google.com; s=arc-20160816; b=D37lM8uOO18XHJIZ7XYOrFXw5xe+HPazT2UC6MThF2YWQw6H5yBk1GtvtV+Zehspep taGY6oABWMZyIUPoFvc5mw8jeaozbMjOxP/pqgbLv6WqMrS8Nm4aAWZ/72WcEp9Ter9j ZGweQUaP7H7wjA3LyttzuVBM/NLAKaKA9z/AydBPdVGJOxtkr4KygjWsdNP4T2VwefqU KYS7v7A6qVUm2idwTa3+4NapEaGzdkb1I3qIERCuvMwnTkzZ8ZwV39Cd/aJaCs1rVWMp tYf4Tg4AUWYWdcwQAtPPhELMyVE0b5igV3XHwA9svk1+COJ1D6E3oDyV729RI4xydAbz PgrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=e7/fxenuTWV+ZHejBXYF2Wy3/oCdLqMaDLU9pE4Z8hs=; b=PotcolGR56BZkoVjggD+iujHHt6vtXPL9jIc+XkojXw40/capOczSsqfO/TpswcNV8 LBElcZCAiOZsmwk3VRA8hq/WgjKaethWVu2MVFiFQ3SyGpeb49pWYDVgced3m7eoa+7Q rmeO/UFTOp58zCPEzcSSZgKXMWqJVI6G6+/5HIG5k4ofQGgX0jND81eVD3fMUapTyaE6 zC3DSAixpwJoE53Hkn/I4oXTpffqUUbXgUrrsZqppmX5JiHU17B8yBsSZzEvVGnhrPGv LFe8jTUMO/Mu+zCtvqjGMJMXFoozxa2de5SifUo8dT29A3UhdRN/C8qfgi252teR8VVt S6Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CE1wsKvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp41si15737883ejc.456.2020.11.18.23.12.29; Wed, 18 Nov 2020 23:12:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CE1wsKvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbgKSHKd (ORCPT + 99 others); Thu, 19 Nov 2020 02:10:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbgKSHKc (ORCPT ); Thu, 19 Nov 2020 02:10:32 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CC34C0613CF; Wed, 18 Nov 2020 23:10:32 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id t21so3403039pgl.3; Wed, 18 Nov 2020 23:10:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e7/fxenuTWV+ZHejBXYF2Wy3/oCdLqMaDLU9pE4Z8hs=; b=CE1wsKvPy/0fCr3uTcXsGDwrKPZ/MRn7d6nzFipNXN9B+sjT8ybFvqX64HllkymK1b XhE/ZplTLY8v3L3TQ0NpFhLfn5GsAtNys7HWre3Dj+kzBmnSrdShau1oNiB70AXdXO5g boZH9PEsLuVWwhwAJUyG35r5alhEq+E5k5QZjLpwA3dfgPmWUoMIQippx3flTRyrv4b2 trKilY8hMgi2io/6LAsyekKnFislp7Yo7rAGmEIBqOixQrolTgJfmx5OCAPw09OKbXoa dPZjs4iDOxUrXAOWmw6X23DyhnR5GYZLbR13o/jxY9fW6zR/hPVv2ml/pJbOQnQY5Exa Nrbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e7/fxenuTWV+ZHejBXYF2Wy3/oCdLqMaDLU9pE4Z8hs=; b=gCKuhLYED7pP6GgYXTYOwL+voMCjaVd/i/X2c2XOFqmULI8HqB7prEzD92mQkeQmMV Q5qojUzTmldYu4h3+O4juORxvxK+xw31Idq06FRKMS2TucVi+T0IPZNlcsy2chde4Bum dyemVWqFXuZMQ87ZHQpKFRnt4GbGHmR6kYj6xcaKX3LlHyA+24683dUxwM7EtKAyaCzc 60bWSixBM6Q7TAGXj0/Tu50XJrBXU11wt05b6EcWM02gNJgdkXAJ85WTkCll5idnv6QJ I2q+jLaIWp12YjMb8ZIDHvUbG8Fq5LwiVZ1I2va67GDF/NZnpPGDV9J6FDeZZtenO8cb Vh0Q== X-Gm-Message-State: AOAM530kV4ZO6QIktZhHD3tlbmFHg1NXmI3S20lp2A68pnhxfNKdU0Jx zmhAYq/feMv+I5BuvBscSe0O+fpJdWw= X-Received: by 2002:a63:ba1d:: with SMTP id k29mr11491095pgf.179.1605769832219; Wed, 18 Nov 2020 23:10:32 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id 26sm24963649pgm.92.2020.11.18.23.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 23:10:31 -0800 (PST) Date: Wed, 18 Nov 2020 23:10:29 -0800 From: Dmitry Torokhov To: Alexandru Ardelean Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] Input: adp5589: use devm_gpiochip_add_data() for gpios Message-ID: <20201119071029.GF2034289@dtor-ws> References: <20201112074308.71351-1-alexandru.ardelean@analog.com> <20201112074308.71351-5-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112074308.71351-5-alexandru.ardelean@analog.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 09:43:07AM +0200, Alexandru Ardelean wrote: > This change makes use of the devm_gpiochip_add_data() function. With this > the gpiochip_remove() function can be removed, and the > adp5589_gpio_remove() function as well. > > The kpad->export_gpio variable is also redundant now, and has been removed. > > Signed-off-by: Alexandru Ardelean Applied, thank you. -- Dmitry